V2.9.3 #4580
V2.9.3 #4580
Conversation
Prior to this commit if you sent a request from an origin not listed in `allowed_origins` we would respond with `null` for the `Access-Control-Allow-Origin` header. Per [https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin#Directives](mozilla's documentation) null should not be used as some clients will allow the request to go through. This commit returns the first of our allowed origins if the requesting origin is not a supported origin.
|
To get the build to work I needed to remove lint api spec target - cec76ec. There were some weird Travis build errors (e.g. https://travis-ci.org/StackStorm/st2/jobs/502377959) due to I also tried to remove Travis cache, etc. without success. If we will encounter same issues in master in the future we might have no choice but to temporary fork Another approach / workaround would also be to create a separate virtualenv just for Again, nothing worth doing for v2.9.3 (would take too much effort), but something to keep in mind if we encounter similar issues in master. |
|
I also cherry picked fix from #4505 to avoid Travis unit tests from running 50+ minutes instead of ~15. |
2.9.3 patch for CORS security fix.