-
-
Notifications
You must be signed in to change notification settings - Fork 782
fix transitive dep on more-itertools for python 2.7 #4843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Cool, thanks for the efforts! @Kami might have more ideas as we discussed it recently. |
7313160 to
176034a
Compare
st2tests/requirements.txt
Outdated
| # update the component requirements.txt | ||
| RandomWords | ||
| mock==2.0.0 | ||
| more-itertools<=5.0.0; python_version < "3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, for that notation, a more recent version of distutils / setuptools needs to be available during package create and install time, right?
|
I'm fine with those changes as long as they don't break out package build process (I believe they shouldn't as long as a more recent version of setuptools and distutils is used there). |
176034a to
19d26f3
Compare
|
I just updated the commits to use |
|
As far as setuptools versioning: setuptools-20.2 added PEP 508 environment marker support, and had many fixes through 20.10 (see here) I'm not sure how to check the version of distutils. Isn't that part of stdlib? |
|
It looks like the packaging docker containers are installing setuptools, but no version is pinned. |
Without this change I could not successfully run
make requirementsormake linton python 2.7.Something is pulling in more-itertools, but the metadata for more-itertools is confusing pip so it is selecting a version that is python 3 only when it should be installing more-itertools 5.0.0 or less on python 2.7.
This takes the shotgun approach to fixing that. It includes the dep for all st2 packages. If anyone cares to evaluate the tree of deps to only include this where needed, be my guest.
Note that this includes a fix for the fixate-requirements script to allow including the python_version marker.