Skip to content

Conversation

@cognifloyd
Copy link
Member

Without this change I could not successfully run make requirements or make lint on python 2.7.

Something is pulling in more-itertools, but the metadata for more-itertools is confusing pip so it is selecting a version that is python 3 only when it should be installing more-itertools 5.0.0 or less on python 2.7.

This takes the shotgun approach to fixing that. It includes the dep for all st2 packages. If anyone cares to evaluate the tree of deps to only include this where needed, be my guest.

Note that this includes a fix for the fixate-requirements script to allow including the python_version marker.

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Jan 15, 2020
@claassistantio
Copy link

claassistantio commented Jan 15, 2020

CLA assistant check
All committers have signed the CLA.

@arm4b arm4b added the bug label Jan 15, 2020
@arm4b
Copy link
Member

arm4b commented Jan 15, 2020

Cool, thanks for the efforts!

@Kami might have more ideas as we discussed it recently.

@arm4b arm4b requested a review from Kami January 15, 2020 23:14
@cognifloyd cognifloyd force-pushed the more_itertools_fix branch 3 times, most recently from 7313160 to 176034a Compare January 16, 2020 04:14
# update the component requirements.txt
RandomWords
mock==2.0.0
more-itertools<=5.0.0; python_version < "3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, for that notation, a more recent version of distutils / setuptools needs to be available during package create and install time, right?

@Kami
Copy link
Member

Kami commented Jan 16, 2020

I'm fine with those changes as long as they don't break out package build process (I believe they shouldn't as long as a more recent version of setuptools and distutils is used there).

@cognifloyd
Copy link
Member Author

I just updated the commits to use ; instead of just ; (space before and after) because I came across an odd bug that suggested the space was required in some cases.

@cognifloyd
Copy link
Member Author

As far as setuptools versioning:
We are installing setuptools-41.0.1 as part of the dev environment.
I don't see any current setuptools or distutils version requirements.

setuptools-20.2 added PEP 508 environment marker support, and had many fixes through 20.10 (see here)
CentOS 7 comes with 0.9.8
CentOS 6 comes with 0.6.10
Ubuntu 14.04 comes with 3.3
Ubuntu 16.04 comes with 20.7
Ubuntu 18.04 comes with 39.0
I'm not sure where to check which version is used during the package build process.

I'm not sure how to check the version of distutils. Isn't that part of stdlib?

@cognifloyd
Copy link
Member Author

It looks like the packaging docker containers are installing setuptools, but no version is pinned.
https://github.com/StackStorm/st2packaging-dockerfiles/tree/master/packagingbuild

@cognifloyd cognifloyd deleted the more_itertools_fix branch February 12, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug size/S PR that changes 10-29 lines. Very easy to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants