Fix to st2client install check #4847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Member
|
Related #4843 Looks like Travis is still not happy about some of st2client dependencies, according to https://travis-ci.org/StackStorm/st2/jobs/639637822 |
Contributor
Author
|
@armab This is a new and different error. |
The make .st2client-install-check command is failing because latest more-itertools no longer supports python 2.7. To workaround, pin more-itertools to an older version.
When running st2client install check, the requirement zipp>=0.5 will install zipp 2.0.0 which will registered as 0.0.0 that fails the st2client install check. This is likely an upstream error. The zipp requirement is pinned to >=0.5,<=1.0.0 to workaround the issue.
m4dcoder
force-pushed
the
fix-more-itertools
branch
from
4c58157 to
4aa2a8a
Compare
arm4b
reviewed
Jan 20, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Would be good to include Changelog record for that fix as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The make .st2client-install-check command is failing because latest more-itertools no longer supports python 2.7. To workaround, pin more-itertools to an older version. The zipp requirement is pinned to >=0.5,<=1.0.0 because the latest 2.0.0 version is registered as 0.0.0 and causing install check to fail.
Closes #4843