try to support tooz in EL8/py3 #4904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Member
|
Looks like CI is not happy with that requirements definition |
arm4b
suggested changes
Dec 14, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Considering we're Python 3 only now which unblocks this PR, please update the code to include the latest tooz.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Tooz < 2.2.0 doesn't support consul heartbeat. @nmaludy Got it committed to tooz: openstack/tooz@6e750b6#diff-ac4db250c2e1f5b2d95e610996274b96.
I have tested this and updated fixed-requirements.txt as follows:
The question is - will this build correctly? It seems to me (@blag ) that the make requirements script doesn't put both lines in the generated requirements files.
Proof that it works:
