Skip to content

Conversation

@hnanchahal
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hnanchahal
❌ hanancha


hanancha seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Nov 18, 2020
@arm4b arm4b added the feature label Nov 18, 2020
@arm4b
Copy link
Member

arm4b commented Nov 18, 2020

The Packages build succeeded for EL7/EL8, but failed for the Ubuntu 16 and 18:
https://app.circleci.com/pipelines/github/StackStorm/st2/566/workflows/c0fa8b59-6fdf-402e-998b-605fc490050e/jobs/11867/parallel-runs/1?filterBy=FAILED

[wheelhouse: st2]         #include "lber.h"
[wheelhouse: st2]                  ^~~~~~~~
[wheelhouse: st2]        compilation terminated.
[wheelhouse: st2]        error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
[wheelhouse: st2]        ----------------------------------------
[wheelhouse: st2]        ERROR: Failed building wheel for python-ldap

lber.h indicates it needs some ldap dev dependencies to build the wheel which I can found here: https://github.com/StackStorm/st2packaging-dockerfiles/blob/master/buildpack/bionic/Dockerfile#L16

And so we'll need to add them in a PR against the https://github.com/StackStorm/st2-packages/blob/master/packages/st2/debian/control where the deb/rpm packages build happens:
Build-Depends: libldap2-dev, libsasl2-dev

Can you please open a PR against the https://github.com/StackStorm/st2-packages/ to include those changes as well?

@arm4b
Copy link
Member

arm4b commented Nov 18, 2020

Lint/Unit tests are also signalize a required change, see instructions here: https://travis-ci.org/github/StackStorm/st2/jobs/744318241#L1508-L1520 Because new auth backend was added by default, st2.conf needs a re-generation to include that.

@arm4b
Copy link
Member

arm4b commented Nov 18, 2020

From the CLA standpoint #5081 (comment),

hanancha seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA.

Looks like 1 commit is coming from the non-Github user: 0d81983 while others are good. If you could re-work the commit history for your branch to include contributions from your github account, - it'll make the CLA check pass.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size/XS PR that changes 0-9 lines. Quick fix/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants