Adding libldap2-dev, libsasl2-dev to satisfy ldap dependencies #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
suggested changes
Nov 18, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Thanks for PR!
Left one comment to address.
packages/st2/debian/control
Outdated
| Architecture: any | ||
| Pre-Depends: dpkg (>= 1.16.16), ${pre:Depends}, ${misc:Pre-Depends}, adduser | ||
| Depends: ${shlibs:Depends}, ${misc:Depends}, sudo, adduser, ${Depends}, libssl-dev, libffi-dev, git, libpam0g, openssh-server, openssh-client, bash, netbase | ||
| Depends: ${shlibs:Depends}, ${misc:Depends}, sudo, adduser, ${Depends}, libssl-dev, libffi-dev, git, libpam0g, openssh-server, openssh-client, bash, netbase, libldap2-dev, libsasl2-dev |
Member
There was a problem hiding this comment.
Per StackStorm/st2#5081 (comment)
we'll need to add these dependencies via Build-Depends: as they're required only for build.
Member
|
Dockerfiles updates (StackStorm/st2packaging-dockerfiles#93) worked, merging as tests now ✔️ |
arm4b
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of StackStorm/st2#5081, StackStorm/st2#5082