Adding ldap support as auth backend #5082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Member
|
This time CLA is happy, thanks for that! 👍 Let's work in this PR if any more changes needed. |
arm4b
reviewed
Nov 18, 2020
pull-request-size
bot
added
size/S
arm4b
approved these changes
Nov 19, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
All tests passed. Merging.
Thanks for the contribution @hnanchahal! 👍
The new version will be available in 3.4dev Docker images today/tomorrow after automatic scheduled build/deploy/promotion.
As a follow-up, can you please also update the documentation here? https://docs.stackstorm.com/authentication.html#ldap-enterprise-edition (Github source: https://github.com/StackStorm/st2docs/blob/master/docs/source/authentication.rst)
Reword the LDAP configuration section removing Enterprise mentions as LDAP is part of the ST2 OSS core now.
This was referenced Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate LDAP auth https://github.com/StackStorm/st2-auth-ldap into st2 core.