Update nginx config to support TLS v1.3 in addition to TLS v1.2 #5280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addition to TLS v1.2) when nginx is compiled against openssl v1.1.1 which supports TLS v1.3.
/# with '#' will be ignored, and an empty message aborts the commit.
pull-request-size
bot
added
the
size/S
arm4b
approved these changes
Jun 3, 2021
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Thanks a lot, @Kami 👍
and @cognifloyd, @punkrokk for assistance!
Member
|
Thinking that this user-affecting change probably worth a small note in the upcoming Release Announcement |
Member
|
Do we also need a small remark in the https://docs.stackstorm.com/upgrade_notes.html ? |
cognifloyd
approved these changes
Jun 3, 2021
punkrokk
approved these changes
Jun 3, 2021
Member
punkrokk
left a comment
punkrokk
left a comment
There was a problem hiding this comment.
Looks good. Regarding ciphers, anything < 256 should get removed. Not critical as I think browsers these days want the harder ciphers.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates production + sample nginx configs to also support TLS v1.3 in addition to TLS v1.2.
Keep in mind that TLS v1.3 will only be used if the server and client support it. On the server side, this means it will work out of the box on more recent distros where nginx version is >= v1.13 and nginx is compiled against OpenSSL v 1.1.1 which supports TLS v1.3.
Resolves #5216.