RFR: Timer should not be sensor

[lakshmi-kannan]

What?

Timer is not a sensor anymore. It would now be part of st2 process (rules_engine for now but we can move if needed)

Things fixed

• st2reactor/contrib doesn't exist anymore as webhook and timers are now moved.
• Registration of system trigger models now happen programatically (in webhook controller and st2timer) as opposed to bootstrap script based registration.
• Also with this PR, I refactored st2reactor/container/utils and moved trigger type creation method to st2common/services/triggers so it can be shared.

TODO

• REFACTOR: st2reactor/container/utils needs some refactor love. #913

[Kami]

Nice - going forward, under which service / where the timer will run?

[lakshmi-kannan]

Nice - going forward, under which service / where the timer will run?

I am thinking RulesEngine. Thoughts?

[Kami]

@lakshmi-kannan Honestly not sure aka haven't decided yet what's the best place for it.

[lakshmi-kannan]

I have no idea what this test was trying to achieve. I removed this test. Let me know if anyone has objections.

[lakshmi-kannan]

@Kami For now, I put the timer in rules_engine. We can change this later if needed.

[Kami]

Sweet, we can finally get rid of this "hack" - we just need to make sure we never put any sensors in the core pack otherwise it's going to break (we won't detect those sensors).

[Kami]

After a quick pass it looks good, but we also need to add test cases for it.

And I also want to test it before merging to make sure we aren't introducing any regressions.

[lakshmi-kannan]

After a quick pass it looks good, but we also need to add test cases for it.

Do you mean the timer? I am planning to add some. Was thinking another PR. Let me get started on that.

[Kami]

@lakshmi-kannan Yep and ideally we would do it in this PR :)

[lakshmi-kannan]

@Kami https://github.com/StackStorm/st2/pull/921/files (opened a PR against this PR inception style)

[lakshmi-kannan]

Let's see if I can resolve the merge conflict and get this merged today. Challenge accepted.