RFR: Fix action registration validation

[lakshmi-kannan]

Action registration now uses same validation as actions API. This will fix a lot of issues where registration can let some models pass through but actions list API will break.

[Kami]

Nice.

I believe there is a same issue with rules - we don't perform the same validation on the way in and out.

[Kami]

I find those ifs slightly confusing.

It seems like we always want to use pack argument which is passed to the method so those ifs are redundant / confusing.

[Kami]

Also, action metadata doesn't need and shouldn't define pack attribute anyway, right?

[lakshmi-kannan]

Yes. That is why all these ifs are needed. If metadata doesn't contain a pack field. we add it. The case where user specifies a pack_field but doesn't match the folder it's coming from is an interesting case. I currently throw an exception. We can silently ignore the pack field and override it with the pack but that might confuse the user.

On a related note, st2 action create /full/path seems to register actions in default pack. In that case, pack field is required if you want that model to go into right pack.

[Kami]

Ah, thanks, I got it - we need to support a use case of specifying a pack in case user explicitly registers an action using the API.

Maybe it would be good to document this here :)

[Kami]

Tried to test this branch and everything blew up after I ran register-content script.

It looks like that again, same as the previous PR, this branch changes behavior - we don't update existing actions anymore on register content.

This needs to be fixed so we preserve the old behavior with updating actions on registering.

json.
2014-12-29 17:20:02,481 INFO [-] Action <ResourceReference pack=libcloud,name=enable_cdn_for_container,ref=libcloud.enable_cdn_for_container> found. Will be updated from: ActionDB(description="Enable CDN for container and return the CDN URL", enabled=True, entry_point="enable_cdn_for_container.py", id=54917f740640fd34b644066e, name="enable_cdn_for_container", pack="libcloud", parameters={u'credentials': {u'required': True, u'type': u'string', u'description': u'Name of the credentials set (as defined in the config) to use.'}, u'container_name': {u'required': True, u'type': u'string', u'description': u'Name of the container to enable the CDN for.'}}, runner_type={u'name': u'run-python'}) to: {u'name': u'enable_cdn_for_container', u'parameters': {u'credentials': {u'required': True, u'type': u'string', u'description': u'Name of the credentials set (as defined in the config) to use.'}, u'container_name': {u'required': True, u'type': u'string', u'description': u'Name of the container to enable the CDN for.'}}, u'description': u'Enable CDN for container and return the CDN URL', u'enabled': True, u'entry_point': u'enable_cdn_for_container.py', 'pack': 'libcloud', u'runner_type': u'run-python'}
2014-12-29 17:20:02,496 ERROR [-] Failed to write action to db enable_cdn_for_container.
Traceback (most recent call last):
  File "/data/stanley/st2actions/st2actions/bootstrap/actionsregistrar.py", line 71, in _register_action
    model = Action.add_or_update(model)
  File "/data/stanley/st2common/st2common/persistence/__init__.py", line 73, in add_or_update
    model_object = kls._get_impl().add_or_update(model_object)
  File "/data/stanley/st2common/st2common/models/db/__init__.py", line 144, in add_or_update
    instance.save()
  File "/data/stanley/virtualenv/local/lib/python2.7/site-packages/mongoengine/document.py", line 286, in save
    raise NotUniqueError(message % unicode(err))
NotUniqueError: Tried to save duplicate unique keys (E11000 duplicate key error index: st2.action_d_b.$pack_1_name_1  dup key: { : "libcloud", : "enable_cdn_for_container" })

[Kami]

This appears to be the same bug as the one introduced in #926 and later fixed #927, but this time it's actions and not sensors.

[Kami]

I also need to have a look how my tests which I've added recently didn't catch that. They should catch this problem :/