Skip to content

Conversation

@hnanchahal
Copy link
Contributor

@hnanchahal hnanchahal commented Nov 30, 2020

Closes #1038

Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. One minor comment.

Previously we mentioned that there was a need to add admin privileges to Stanley user. If we install the community RBAC does that get added by the bash installer or do you have to do that manually?

I think we should mention which happens.

@amanda11 amanda11 added this to the 3.4.0 milestone Dec 3, 2020
@amanda11
Copy link
Contributor

amanda11 commented Dec 3, 2020

I'm not sure what has happened, but this PR now only contains LDAP changes, rather than the RBAC ones @armab

@arm4b
Copy link
Member

arm4b commented Dec 3, 2020

Thanks @amanda11, fixed now!
I fat-fingered it today while trying to do several things in parallel. Rarely works well :)

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arm4b arm4b merged commit e745aff into StackStorm:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RBAC doc update after feature transition enterprise -> st2 OSS core

3 participants