Skip to content

Additional tests for --python3 flag and functionality #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kami merged 5 commits into from
May 13, 2019
Merged

Additional tests for --python3 flag and functionality #158

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7736e5
Add a test case for PYTHONPATH when using --python3 flag.
Kami May 9, 2019
52c97b6
Add another test case for it.
Kami May 9, 2019
36d1713
Update tests.
Kami May 13, 2019
06198c7
Fix tests.
Kami May 13, 2019
0dc2bbe
Update it so it also works on distros where non standard prefix is used.
Kami May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions cli/test_pack_python3.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@

load '../test_helpers/bats-support/load'
load '../test_helpers/bats-assert/load'



STATUS_SUCCESS='"status": "succeeded'

setup() {
Expand Down Expand Up @@ -36,9 +33,12 @@ teardown() {
st2 run packs.uninstall packs=examples
fi
[[ ! -d /opt/stackstorm/packs/examples ]]
}


if [[ -d /opt/stackstorm/packs/python3_test ]]; then
st2 run packs.uninstall packs=python3_test
fi
[[ ! -d /opt/stackstorm/packs/python3_test ]]
}

@test "packs.setup_virtualenv without python3 flags works and defaults to Python 2" {
SETUP_VENV_RESULTS=$(st2 run packs.setup_virtualenv packs=examples -j)
Expand All @@ -65,7 +65,6 @@ teardown() {

run eval "echo '$SETUP_VENV_RESULTS' | jq -r '.status'"
assert_success

assert_output "succeeded"

run /opt/stackstorm/virtualenvs/examples/bin/python --version
Expand All @@ -84,4 +83,28 @@ teardown() {

run eval "echo '$RESULT' | jq -r '.status'"
assert_output "succeeded"

# Verify PYTHONPATH is correct
RESULT=$(st2 run examples.python_runner_print_python_environment -j)
assert_success

run eval "echo '$RESULT' | jq -r '.result.stdout'"
assert_success
assert_output --regexp ".*PYTHONPATH: /usr/(local/)?lib/python3.*"
}

@test "python3 imports work correctly" {
run st2 pack install python3_test --python3 -j
assert_success

RESULT=$(st2 run python3_test.test_stdlib_import -j)
assert_success

run eval "echo '$RESULT' | jq -r '.result.result'"
assert_success
assert_output --partial "imports work correctly"

run eval "echo '$RESULT' | jq -r '.result.stdout'"
assert_success
assert_output --partial "Using Python version: 3."
}