Test for notify-errbot, since rule is added to chatops pack. #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't know that the order of the listing is stable, so specifying indexes like that may make this test brittle. Merging this will also make tests fail until StackStorm/st2#5051 is merged. See my PR #195 for how to do this in what I think is a better way to test for this. Alternatively, we can merge in #194, then merge #5051, and then merge in #195. That will keep tests passing, and minimize the number of merges that need to happen at the same time. |
Contributor
Author
|
Closing this PR in favour of #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update e2e tests for chatops. Reference: StackStorm/st2#5051