Allow errbot notify rule #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 17, 2020
nmaludy
approved these changes
Nov 17, 2020
blag
force-pushed
the
allow-errbot-notify-rule
branch
3 times, most recently
from
3cf51bb to
62145ef
Compare
blag
force-pushed
the
allow-errbot-notify-rule
branch
from
62145ef to
cefca57
Compare
Contributor
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged after #194 and StackStorm/st2#5051 (this branch will need to be rebased).
This PR adds a check for the
chatops.notify-errbotrule, similar to how #194 checks forchatops.notify, but without relying on the ordering of the rule listing (so this test is less brittle).