Skip to content

Drop front end font icon code#1741

Merged
Crabcyborg merged 1 commit into
masterfrom
drop_front_end_font_icon_code
May 13, 2024
Merged

Drop front end font icon code#1741
Crabcyborg merged 1 commit into
masterfrom
drop_front_end_font_icon_code

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

This was here for supporting Signatures.

Version v3.0.4 of Signatures has been live now since March 28th so it should be safe to remove this logic.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2024

Walkthrough

The recent updates involve deprecating the function maybe_include_font_icon_css() in the FrmStylesHelper.php file, marking it with the @deprecated annotation and redirecting its functionality to _deprecated_function(). Additionally, references to this deprecated function have been removed from the custom_theme.css.php file to align with the updated codebase.

Changes

File Change Summary
classes/.../FrmStylesHelper.php Deprecated maybe_include_font_icon_css() by using @deprecated annotation and _deprecated_function().
css/custom_theme.css.php Removed the call to FrmStylesHelper::maybe_include_font_icon_css().

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c306297 and eeb3edb.
Files selected for processing (2)
  • classes/helpers/FrmStylesHelper.php (2 hunks)
  • css/custom_theme.css.php (1 hunks)
Files skipped from review due to trivial changes (1)
  • css/custom_theme.css.php

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Crabcyborg Crabcyborg merged commit 9e4b2e0 into master May 13, 2024
@Crabcyborg Crabcyborg deleted the drop_front_end_font_icon_code branch May 13, 2024 14:51
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment on lines +726 to +732
* @since 5.5.1
* @deprecated x.x
* @return void
*/
public static function maybe_include_font_icon_css() {
_deprecated_function( __METHOD__, 'x.x' );
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'x.x' with the actual version number in the deprecation annotation and method call.

- * @deprecated x.x
- _deprecated_function( __METHOD__, 'x.x' );
+ * @deprecated [actual_version_number]
+ _deprecated_function( __METHOD__, '[actual_version_number]' );

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
* @since 5.5.1
* @deprecated x.x
* @return void
*/
public static function maybe_include_font_icon_css() {
_deprecated_function( __METHOD__, 'x.x' );
}
* @since 5.5.1
* @deprecated [actual_version_number]
* @return void
*/
public static function maybe_include_font_icon_css() {
_deprecated_function( __METHOD__, '[actual_version_number]' );
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant