Drop most font icon references

[Crabcyborg]

I kept 2 for now that are likely still in circulation: frm_delete_icon and frm_tooltip_icon. There is also other code still supporting frm_add_tag and frm_remove_tag that is still being used that is kept.

The rest shouldn't be in use anymore. If any are, hopefully this update will help detect those.

This update helps remove about 10kb from the frm_admin.css file.

If we keep the woff file alone for now, it should be easy to patch any issues with some quick css.

[coderabbitai]

Walkthrough

The pull request removes most icon font glyph mappings from the SCSS source file while preserving the tooltip icon rule and reintroducing the delete icon mapping. Corresponding CSS declarations are added to define the tooltip and delete icon content values explicitly.

Changes

Cohort / File(s)	Summary
Icon Font Stylesheet Updates resources/scss/font_icons.scss	Removes majority of predefined icon font rules (many .frm_*-icon::before blocks); retains .frm_tooltip_icon::before unchanged; reintroduces .frm_delete_icon::before with content: "\e610" !important
Icon Font CSS Declarations css/font_icons.css	Adds two new CSS rules: .frm_tooltip_icon::before with content "\e611" and .frm_delete_icon::before with content "\e610" !important

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Drop front end font icon code #1741: Deprecates and removes the helper function that enqueues the font icon CSS file, complementing the reduction of icon font usage
• Remove old styles for pro features using icon fonts #1779: Removes legacy icon-font rules and mappings from CSS, part of the same icon font refactoring effort
• Stop using font icons for email bcc/cc/reply to remove icons #1814: Replaces font-icon glyph mappings with SVG implementations for specific icon types (CC/BCC/Reply), indicating broader icon system modernization

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request has no description provided by the author, making it impossible to verify that the stated intent aligns with the changeset.	Add a pull request description explaining the reasoning for dropping most font icon references and confirming this aligns with the project's goals.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Drop most font icon references' accurately and clearly summarizes the main change—removing the majority of icon font rules while preserving specific ones.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

resources/scss/font_icons.scss (1)

76-81: Inconsistent use of !important between icon rules.

The .frm_tooltip_icon::before rule (line 77) omits !important, while .frm_delete_icon::before (line 81) includes it. If the !important is needed on the delete icon to override a specific conflicting rule, consider adding a brief comment explaining why. Otherwise, for consistency, either add !important to the tooltip icon or remove it from the delete icon.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3de75a3 and e640092.

📒 Files selected for processing (3)

• css/font_icons.css
• css/frm_admin.css
• resources/scss/font_icons.scss

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: Cypress

🔇 Additional comments (1)

css/font_icons.css (1)

1-1: LGTM!

The compiled CSS correctly reflects the SCSS source changes, with both .frm_tooltip_icon::before and .frm_delete_icon::before rules properly included.