Stop using font icons for email bcc/cc/reply to remove icons

[Crabcyborg]

Related issue https://github.com/Strategy11/formidable-pro/issues/5063

This update updates some old font icon code to use FrmAppHelper::icon_by_class instead.

[coderabbitai]

Walkthrough

The recent changes focus on refining the HTML and CSS handling of email settings in a form. This includes updating CSS classes for better icon presentation, adding specific classes to input fields for clearer differentiation, and enhancing tooltips. These improvements streamline user interactions when configuring CC, BCC, and Reply To fields in email forms.

Changes

Files	Change Summary
classes/views/.../_email_settings.php	Updated HTML structure, refined icon classes for CC, BCC, and Reply To, added specific CSS classes to input fields, enhanced tooltip management.
css/frm_admin.css	Added CSS rule for positioning an SVG element in email fields' remove button.

Sequence Diagram(s)

The changes primarily involve HTML and CSS modifications without altering control flows, making sequence diagrams unnecessary.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 215a505 and e9097ce.

Files selected for processing (2)

• classes/views/frm-form-actions/_email_settings.php (2 hunks)
• css/frm_admin.css (1 hunks)

Additional context used

Biome

css/frm_admin.css

[error] 9058-9058: Expected a string but instead found ')'. (parse)

Expected a string here.

Additional comments not posted (4)

classes/views/frm-form-actions/_email_settings.php (3)

23-26: The update to use FrmAppHelper::icon_by_class for the icon in the CC field is consistent with modern practices of handling icons, improving scalability and maintainability by using a helper function instead of hardcoding classes.

---

62-62: Updating the Reply To field to use FrmAppHelper::icon_by_class maintains consistency across the form fields and leverages the helper function for better icon management. This should simplify future updates or changes to iconography.

---

32-35: Similar to the CC field, the BCC field now uses FrmAppHelper::icon_by_class for icon management. This change enhances the flexibility and future-proofing of the icon's implementation. Ensure that the FrmAppHelper::icon_by_class function is thoroughly tested to handle different scenarios and icon classes.

css/frm_admin.css (1)

6169-6172: The new CSS rules for positioning SVG icons look good. Ensure to verify the visual layout across different browsers and screen sizes.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.