Skip to content

Pro issue 5058 update form button settings #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 3 commits into from
May 28, 2024
Merged

Pro issue 5058 update form button settings #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc5a47b
Pro issue 5058 / Update form button settings
Crabcyborg May 28, 2024
b6a848a
Remove the hidden input from the view
Crabcyborg May 28, 2024
bcf83f0
Put back function descripion
Crabcyborg May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions classes/controllers/FrmFormsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1429,6 +1429,7 @@ private static function get_settings_tabs( $values ) {
* @since 4.0
*
* @param array $values
* @return void
*/
public static function advanced_settings( $values ) {
$first_h3 = 'frm_first_h3';
Expand All @@ -1438,6 +1439,7 @@ public static function advanced_settings( $values ) {

/**
* @param array $values
* @return void
*/
public static function render_spam_settings( $values ) {
if ( function_exists( 'akismet_http_post' ) ) {
Expand All @@ -1451,20 +1453,17 @@ public static function render_spam_settings( $values ) {
* @since 4.0
*
* @param array $values
* @return void
*/
public static function buttons_settings( $values ) {
$styles = apply_filters( 'frm_get_style_opts', array() );

$frm_settings = FrmAppHelper::get_settings();
$no_global_style = $frm_settings->load_style === 'none';

include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-buttons.php';
}

/**
* @since 4.0
*
* @param array $values
* @return void
*/
public static function html_settings( $values ) {
include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-html.php';
Expand All @@ -1476,6 +1475,7 @@ public static function html_settings( $values ) {
* @since 2.03.08
*
* @param array|bool $values
* @return void
*/
private static function clean_submit_html( &$values ) {
if ( is_array( $values ) && isset( $values['submit_html'] ) ) {
Expand Down Expand Up @@ -1947,6 +1947,7 @@ public static function json_error( $errors ) {
* Education for premium features.
*
* @since 4.05
* @return void
*/
public static function add_form_style_tab_options() {
include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/add_form_style_options.php';
Expand Down Expand Up @@ -3235,14 +3236,6 @@ public static function create( $values = array() ) {
self::update( $values );
}

/**
* @deprecated 4.08
* @since 3.06
*/
public static function add_new() {
_deprecated_function( __FUNCTION__, '4.08' );
}

/**
* @deprecated 6.7
*
Expand Down
18 changes: 4 additions & 14 deletions classes/views/frm-forms/add_form_style_options.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,9 @@
}
?>
<tr>
<td>
<label for="frm_option_transition" class="frm_show_upgrade frm_noallow" data-medium="transitions" data-upgrade="Form transitions">
<?php esc_html_e( 'Page Turn Transitions', 'formidable' ); ?>
</label>
</td>
<td>
<select id="frm_option_transition" >
<option disabled>
<?php esc_html_e( 'Slide horizontally', 'formidable' ); ?>
</option>
<option disabled>
<?php esc_html_e( 'Slide vertically', 'formidable' ); ?>
</option>
</select>
<td colspan="2">
<div class="frm_note_style" style="margin-top: 0;">
<?php esc_html_e( 'Page Turn Transitions setting was moved to the page break field settings in the form builder.', 'formidable' ); ?>
</div>
</td>
</tr>
4 changes: 0 additions & 4 deletions classes/views/frm-forms/settings-buttons.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
die( 'You are not allowed to call this page directly.' );
}
?>
<p class="howto">
<?php esc_html_e( 'Set your button text.', 'formidable' ); ?>
</p>

<input type="hidden" name="options[custom_style]" value="<?php echo esc_attr( $values['custom_style'] ); ?>" />

<table class="form-table">
Expand Down