Pro issue 5058 update form button settings

[Crabcyborg]

Fixes https://github.com/Strategy11/formidable-pro/issues/5058

This update does a few things,

• It updates the buttons settings page to just look like Pro now instead of showing a placeholder input that doesn't exist in Pro anymore. This page isn't terribly marketable and it will be removed soon so I think this is all we need to bother with doing right now.
• I removed an old deprecated FrmFormsController::add_new function that I confirmed isn't being referenced anywhere.
• Added some @return void comments.
• Removed some variables that aren't being used anymore in FrmFormsController::buttons_settings.

[coderabbitai]

Walkthrough

The recent changes primarily involve code cleanup and documentation enhancements. The FrmFormsController.php file saw the addition of @return void annotations to several public static functions, and the removal of a deprecated function. Minor adjustments were made to the form style options and button settings in the views, enhancing clarity and usability.

Changes

File Path	Change Summary
.../controllers/FrmFormsController.php	Added @return void annotations to several functions and removed the deprecated add_new function.
.../views/frm-forms/add_form_style_options.php	Replaced select element for "Page Turn Transitions" with a note about its new location.
.../views/frm-forms/settings-buttons.php	Removed the <p> element with a class of "howto" for setting button text.

Sequence Diagram(s) (Beta)

No sequence diagrams are necessary for these changes as they primarily involve documentation updates and minor UI adjustments.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b6a848a and bcf83f0.

Files selected for processing (1)

• classes/controllers/FrmFormsController.php (6 hunks)

Files skipped from review as they are similar to previous changes (1)

• classes/controllers/FrmFormsController.php

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to full the review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.