Pro issue 5404 / Black friday

[Crabcyborg]

Fixes https://github.com/Strategy11/formidable-pro/issues/5404

[coderabbitai]

Warning

Rate limit exceeded

@Crabcyborg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 0 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between 2e426a0 and 45af60d.

Walkthrough

The changes in this pull request involve modifications to the FrmAppController class and the addition of a new CSS class in the Formidable Forms plugin. A set of private static methods has been introduced to manage Black Friday and Cyber Monday promotions, including the creation of a conditional submenu item in the WordPress admin menu. Additionally, a new CSS class for styling text has been added, along with updates to existing styles to enhance the visual presentation of promotional elements.

Changes

File	Change Summary
classes/controllers/FrmAppController.php	- Added methods: redirect_blackfriday, maybe_add_black_friday_submenu_item, is_black_friday, is_cyber_monday, within_sale_date_range($from, $to) to manage promotional submenu items and date checks.
css/admin/frm_admin_global.css	- Added new CSS class .frm-orange-text for text color. - Updated styles for .frm-new-pill and #adminmenu .frm-new-pill to modify appearance.

Possibly related PRs

• Pro issue 5074 / Print media templates to fix email actions media but… #1751: This PR adds a new private static method maybe_print_media_templates() in the same FrmFormsController.php file, indicating a focus on enhancing functionality within the Formidable Forms plugin, similar to the promotional enhancements in the main PR.
• Pro issue 5058 update form button settings #1759: This PR modifies several public static functions in FrmFormsController.php, which may relate to the overall functionality and structure of the plugin, paralleling the changes made in the main PR to enhance user engagement through new features.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)

classes/controllers/FrmAppController.php (2)

1466-1476: Use exit; instead of die(); after wp_redirect()

In the redirect_blackfriday() method, it's recommended to use exit; after wp_redirect() for better clarity and adherence to WordPress coding standards.

Apply this diff to line 1476:

-		die();
+		exit;

---

46-46: Update @since x.x annotations to the actual version

The @since x.x annotations in the docblocks should be updated to reflect the actual version number when the code is released.

Apply this diff:

 	/**
-	 * @since x.x
+	 * @since 6.9
 	 *

(Replace 6.9 with the correct version number.)

Also applies to: 73-73, 84-84, 96-96, 1462-1462

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8cdaf32 and 2e426a0.

📒 Files selected for processing (2)

• classes/controllers/FrmAppController.php (3 hunks)
• css/admin/frm_admin_global.css (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• css/admin/frm_admin_global.css