Fix redirect issues for upgrade and black friday

[Crabcyborg]

This fixes issues with the "headers already sent" PHP warning when trying to redirect using the submenu links.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces significant changes to the FrmAddonsController and FrmAppController classes. The upgrade_to_pro method has been removed from FrmAddonsController, replaced by an anonymous function in the submenu logic. The menu method now checks for the formidable-pro-upgrade submenu item and redirects users accordingly. In FrmAppController, the maybe_add_black_friday_submenu_item method has been modified to create a submenu without direct redirection, centralizing redirect logic in the admin_init method. The redirect_blackfriday method has also been removed.

Changes

File	Change Summary
classes/controllers/FrmAddonsController.php	- Removed method: upgrade_to_pro() - Added anonymous function in submenu creation logic - Updated menu method to redirect based on submenu item presence.
classes/controllers/FrmAppController.php	- Removed method: redirect_blackfriday() - Modified maybe_add_black_friday_submenu_item to use an anonymous function - Centralized redirect logic in admin_init method.

Possibly related PRs

• Remove lite upgrade page in plugin #2028: This PR modifies the upgrade_to_pro method in the FrmAddonsController class, which is directly related to the removal of the same method in the main PR, indicating a significant change in how the upgrade process is handled.
• Add utm content to upgrade ctas #1997: Although this PR focuses on adding UTM content to upgrade CTAs, it is related to the overall upgrade functionality and user experience improvements that are also a focus of the main PR's changes in the FrmAddonsController.
• Pro issue 5404 / Black friday #2020: This PR introduces new functionality related to Black Friday promotions in the FrmAppController, which may intersect with the upgrade process and user redirection logic discussed in the main PR.

Suggested reviewers

• garretlaxton

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.