Skip to content

Remove lite upgrade page in plugin#2028

Merged
Crabcyborg merged 3 commits into
masterfrom
remove_lite_upgrade_page_in_plugin
Oct 4, 2024
Merged

Remove lite upgrade page in plugin#2028
Crabcyborg merged 3 commits into
masterfrom
remove_lite_upgrade_page_in_plugin

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

Fixes https://github.com/Strategy11/formidable-pro/issues/5412

This update removes a step in the upgrade process, removing the page in our plugin and just redirecting to our lite upgrade page directly.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 4, 2024

Warning

Rate limit exceeded

@Crabcyborg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between 3557e89 and 38f62d8.

Walkthrough

The pull request introduces significant changes to the FrmAddonsController class and the associated upgrade view. The upgrade_to_pro method has been modified to remove the previous rendering logic, replacing it with a direct redirect to the upgrade link using wp_redirect. This streamlines the upgrade process by eliminating unnecessary content display. Additionally, the upgrade_to_pro.php view file has been completely removed, replaced with a deprecation notice indicating that the file should no longer be used.

Changes

File Path Change Summary
classes/controllers/FrmAddonsController.php Updated upgrade_to_pro method to remove rendering logic and implement a direct redirect.
classes/views/addons/upgrade_to_pro.php Removed all HTML content and added a deprecation notice using _deprecated_file.

Possibly related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Crabcyborg Crabcyborg added this to the 6.16 milestone Oct 4, 2024
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
classes/controllers/FrmAddonsController.php (2)

871-871: Update the @since tag with the correct version number

The @since tag currently shows 'x.x'. Please replace 'x.x' with the appropriate version number to accurately document when this change occurred.


884-884: Use exit; instead of die(); for consistency

According to WordPress coding standards, exit; is preferred over die(); when terminating execution after a redirect.

Apply this diff to make the change:

-		die();
+		exit;
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 90cd8b1 and 3557e89.

📒 Files selected for processing (2)
  • classes/controllers/FrmAddonsController.php (1 hunks)
  • classes/views/addons/upgrade_to_pro.php (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • classes/views/addons/upgrade_to_pro.php

Comment thread classes/controllers/FrmAddonsController.php
@Crabcyborg Crabcyborg merged commit 013f840 into master Oct 4, 2024
@Crabcyborg Crabcyborg deleted the remove_lite_upgrade_page_in_plugin branch October 4, 2024 12:53
@coderabbitai coderabbitai Bot mentioned this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant