Fix pro issue 5367 / add redirects to visual views upsell and index p…

[Crabcyborg]

…ages

Fixes https://github.com/Strategy11/formidable-pro/issues/5367

Pre-release
formidable-6.14.1b.zip

[coderabbitai]

Walkthrough

The changes introduce three new private static methods in the FrmEntriesController class of the Formidable Forms plugin. These methods manage user redirection based on the status of the Views add-on. Specifically, they redirect users to the Views index page if Views is installed and active, or to the Views upsell page if Views is inactive. Additionally, a helper method is included to handle query parameters during these redirections.

Changes

File	Change Summary
classes/controllers/FrmEntriesController.php	Added three private static methods: maybe_redirect_to_views_index, maybe_redirect_to_views_upsell, and add_url_params_to_views_redirect_query_args.

Possibly related PRs

• Pro issue 5058 update form button settings #1759: Involves modifications to static methods in FrmFormsController.php, which may relate to the overall structure and functionality of the Formidable Forms plugin.

Suggested labels

run analysis, run tests

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f863efb and 722ecb4.

Files selected for processing (1)

• classes/controllers/FrmEntriesController.php (1 hunks)

Additional comments not posted (3)

classes/controllers/FrmEntriesController.php (3)

36-48: LGTM!

The maybe_redirect_to_views_index function is well-implemented and follows best practices. It correctly checks if the current page is the Views admin page and redirects the user to the Views index page if the condition is met. The use of the add_url_params_to_views_redirect_query_args helper function ensures that any additional query parameters are preserved during the redirection.

---

59-72: LGTM!

The maybe_redirect_to_views_upsell function is well-implemented and follows best practices. It correctly checks if the current page is the Views index page and redirects the user to the Views upsell page if the condition is met. The use of the add_url_params_to_views_redirect_query_args helper function ensures that any additional query parameters are preserved during the redirection.

---

80-89: LGTM!

The add_url_params_to_views_redirect_query_args function is well-implemented and follows best practices. It correctly retrieves the values of the show_nav and form query parameters and adds them to the $query_args array. This ensures that any additional query parameters are preserved during the Views-related redirects.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.