Add type check to avoid php warning

[Crabcyborg]

Related ticket https://secure.helpscout.net/conversation/2723585835/211506

This just adds a small check in case the query for add-ons data fails and the views data is unavailable.

PHP Warning:  Trying to access array offset on value of type bool in /var/www/src/wp-content/plugins/formidable/classes/controllers/FrmSimpleBlocksController.php on line 55
PHP Warning:  Trying to access array offset on value of type null in /var/www/src/wp-content/plugins/formidable/classes/controllers/FrmSimpleBlocksController.php on line 55

[coderabbitai]

Walkthrough

The changes in this pull request focus on the FrmSimpleBlocksController class, specifically modifying the block_editor_assets method. The update enhances the condition that checks for the installation of the views_addon, ensuring it is an array before accessing its status['type'] property. This adjustment aims to improve the robustness of the code by preventing potential errors related to the structure of views_addon. The overall functionality and logic of the method remain unchanged.

Changes

File	Change Summary
classes/controllers/FrmSimpleBlocksController.php	Updated the block_editor_assets method to add a check ensuring views_addon is an array before accessing status['type'].

Possibly related PRs

• Fix pro issue 5367 / add redirects to visual views upsell and index p… #1981: This PR introduces methods to handle the status of the Views add-on, which is directly related to the changes made in the FrmSimpleBlocksController class regarding the views_addon checks.

Suggested labels

run analysis, run tests

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

classes/controllers/FrmSimpleBlocksController.php (1)

55-55: Approve the type check addition with a minor suggestion.

The added type check is_array( $views_addon ) effectively addresses the PR objective by preventing PHP warnings when accessing array offsets on non-array values. This change improves the code's robustness and aligns with the PR description.

For improved clarity and to handle all potential cases, consider using the null coalescing operator:

-				'installed' => is_array( $views_addon ) && 'installed' === $views_addon['status']['type'],
+				'installed' => 'installed' === ($views_addon['status']['type'] ?? ''),

This change will return false if any part of the path ($views_addon, ['status'], or ['type']) is not set, without triggering any warnings.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b8af986 and 94d593e.

📒 Files selected for processing (1)

• classes/controllers/FrmSimpleBlocksController.php (1 hunks)