Improve placeholder text style by AbdiTolesa · Pull Request #1767 · Strategy11/formidable-forms

AbdiTolesa · 2024-05-30T08:17:48Z

Fix https://github.com/Strategy11/formidable-pro/issues/4953

Before:

After:

coderabbitai · 2024-05-30T08:17:59Z

Walkthrough

The recent changes focus on the styling of placeholder text in input fields and textareas. This involves setting the font size using a CSS variable (--field-font-size) rather than direct PHP injections and removing the color property for placeholder text, affecting its appearance when disabled.

Changes

File	Summary
`css/_single_theme.css.php`	The font size for placeholder text in inputs and textareas is now set using CSS variables, and the color property for disabled text is removed.
`css/custom_theme.css.php`	Placeholder text in inputs and textareas has adjusted styling to use CSS variables for font size.

Sequence Diagram(s)

No sequence diagrams are necessary for these styling changes as they do not alter control flow or introduce new features.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1b778c1 and dd0c3ee.

Files selected for processing (1)

css/custom_theme.css.php (1 hunks)

Files skipped from review as they are similar to previous changes (1)

css/custom_theme.css.php

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

garretlaxton

This looks great!

truongwp

This looks great! Thanks @AbdiTolesa!

Crabcyborg · 2024-06-03T20:13:29Z

@shervElmi Since you made this issue, I'd like your sign off on the fix.

Thank you!

…ithub.com/Strategy11/formidable-forms into issue-4953-improve_placeholder_text_style

shervElmi

It's good to me @AbdiTolesa, Thanks!

Crabcyborg

Thank you @AbdiTolesa @truongwp @shervElmi and @garretlaxton!

I think we're good to merge this now.

🥳

Improve placeholder text style

ed914db

Add style to more places

ca1fe46

AbdiTolesa requested a review from garretlaxton May 30, 2024 09:51

garretlaxton approved these changes May 31, 2024

View reviewed changes

AbdiTolesa requested a review from truongwp May 31, 2024 09:21

truongwp approved these changes May 31, 2024

View reviewed changes

truongwp requested a review from Crabcyborg May 31, 2024 10:08

Crabcyborg reviewed May 31, 2024

View reviewed changes

Comment thread css/_single_theme.css.php Outdated

Remove adding the font styles to old selectors

fc5f416

AbdiTolesa requested a review from Crabcyborg June 3, 2024 08:11

Crabcyborg requested review from shervElmi and removed request for Crabcyborg June 3, 2024 20:08

Crabcyborg added this to the 6.11 milestone Jun 3, 2024

Crabcyborg added run analysis run tests labels Jun 3, 2024

shervElmi suggested changes Jun 4, 2024

View reviewed changes

Comment thread css/_single_theme.css.php

Move style to custom_theme.css

fa966b7

AbdiTolesa requested a review from shervElmi June 4, 2024 12:05

shervElmi reviewed Jun 4, 2024

View reviewed changes

Comment thread css/custom_theme.css.php Outdated

shervElmi reviewed Jun 4, 2024

View reviewed changes

Comment thread css/_single_theme.css.php

Crabcyborg added run tests and removed run tests labels Jun 12, 2024

Crabcyborg and others added 3 commits June 12, 2024 16:41

Merge branch 'master' into issue-4953-improve_placeholder_text_style

dfe7b71

Move new selectors up

ead4cf8

Merge branch 'issue-4953-improve_placeholder_text_style' of https://g…

1b778c1

…ithub.com/Strategy11/formidable-forms into issue-4953-improve_placeholder_text_style

AbdiTolesa requested a review from shervElmi June 13, 2024 08:32

shervElmi reviewed Jun 13, 2024

View reviewed changes

Comment thread css/custom_theme.css.php Outdated

shervElmi approved these changes Jun 13, 2024

View reviewed changes

shervElmi reviewed Jun 13, 2024

View reviewed changes

Comment thread css/custom_theme.css.php Outdated

A few more updates

dd0c3ee

AbdiTolesa requested a review from shervElmi June 13, 2024 14:53

shervElmi approved these changes Jun 13, 2024

View reviewed changes

AbdiTolesa requested a review from Crabcyborg June 13, 2024 18:48

Crabcyborg reviewed Jun 13, 2024

View reviewed changes

Crabcyborg approved these changes Jun 13, 2024

View reviewed changes

Crabcyborg merged commit 4e46e2f into master Jun 13, 2024

Crabcyborg deleted the issue-4953-improve_placeholder_text_style branch June 13, 2024 19:05

coderabbitai Bot mentioned this pull request Sep 9, 2024

New Add-Ons Page #1802

Merged

coderabbitai Bot mentioned this pull request Sep 24, 2024

Change the UI/UX of conditional logic elements #2006

Merged

coderabbitai Bot mentioned this pull request Oct 4, 2024

Fix border styles for underline styles #2027

Closed

coderabbitai Bot mentioned this pull request Nov 6, 2024

Set aria-invalid to true only on name part input with error #2036

Merged

This was referenced Jan 6, 2025

Address Styling Issues on Entry (Edit/New) and Style Pages #1986

Merged

Add error style to checkbox and radio fields when there is error with them #2207

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve placeholder text style#1767

Improve placeholder text style#1767
Crabcyborg merged 8 commits into
masterfrom
issue-4953-improve_placeholder_text_style

AbdiTolesa commented May 30, 2024 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 30, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

garretlaxton left a comment

Uh oh!

truongwp left a comment

Uh oh!

Uh oh!

Crabcyborg commented Jun 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shervElmi left a comment

Uh oh!

Crabcyborg left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

AbdiTolesa commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

garretlaxton left a comment

Choose a reason for hiding this comment

Uh oh!

truongwp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Crabcyborg commented Jun 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shervElmi left a comment

Choose a reason for hiding this comment

Uh oh!

Crabcyborg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AbdiTolesa commented May 30, 2024 •

edited

Loading

coderabbitai Bot commented May 30, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)