Skip to content

Improve placeholder text style #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 8 commits into from
Jun 13, 2024
Merged

Improve placeholder text style #1767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ed914db
Improve placeholder text style
AbdiTolesa May 30, 2024
ca1fe46
Add style to more places
AbdiTolesa May 30, 2024
fc5f416
Remove adding the font styles to old selectors
AbdiTolesa Jun 3, 2024
fa966b7
Move style to custom_theme.css
AbdiTolesa Jun 4, 2024
dfe7b71
Merge branch 'master' into issue-4953-improve_placeholder_text_style
Crabcyborg Jun 12, 2024
ead4cf8
Move new selectors up
AbdiTolesa Jun 13, 2024
1b778c1
Merge branch 'issue-4953-improve_placeholder_text_style' of https://g…
AbdiTolesa Jun 13, 2024
dd0c3ee
A few more updates
AbdiTolesa Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion css/_single_theme.css.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@
}
.<?php echo esc_html( $style_class ); ?> input::-moz-placeholder,
.<?php echo esc_html( $style_class ); ?> textarea::-moz-placeholder{
color: <?php echo esc_html( $text_color_disabled . $important ); ?>;
Comment thread
shervElmi marked this conversation as resolved.
opacity: 1;
}
.<?php echo esc_html( $style_class ); ?> input:-ms-input-placeholder,
Expand Down
5 changes: 5 additions & 0 deletions css/custom_theme.css.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,11 @@
}

/* These do not work if they are combined */
.with_frm_style input::placeholder,
.with_frm_style textarea::placeholder {
font-size: var(--field-font-size)<?php echo esc_html( $important ); ?>;
}

.with_frm_style .frm_inside_container > input::-moz-placeholder,
.with_frm_style .frm_inside_container > textarea::-moz-placeholder {
opacity: 0 !important;
Expand Down