Remove layout classes when one is added

[Crabcyborg]

Related issue https://github.com/Strategy11/formidable-pro/issues/5103

This fixes the first item in the list, where selecting a layout class doesn't change the layout if there is already a class set.

[coderabbitai]

Warning

Rate limit exceeded

@Crabcyborg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 47 minutes and 0 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 79eb3cc and aef2612.

Walkthrough

The changes in js/formidable_admin.js introduce new functions to manage layout classes for form fields, ensuring no conflicts occur when setting new classes. Specifically, the functions maybeRemoveLayoutClasses, isALayoutClass, and maybeRemoveClasses have been added, and the frmAdminBuildJS function has been updated to utilize these new functionalities.

Changes

Files	Change Summary
js/formidable_admin.js	Added functions maybeRemoveLayoutClasses, isALayoutClass, and maybeRemoveClasses to handle layout classes. Updated frmAdminBuildJS to incorporate these functionalities.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FormidableAdminJS

    User->>FormidableAdminJS: Trigger form field class change
    FormidableAdminJS->>maybeRemoveLayoutClasses: Call with obj and variable
    maybeRemoveLayoutClasses->>isALayoutClass: Check if class is a layout class
    isALayoutClass-->>maybeRemoveLayoutClasses: Return boolean
    maybeRemoveLayoutClasses-->>FormidableAdminJS: Finish removing layout classes
    FormidableAdminJS->>maybeRemoveClasses: Call with beforeValue, removeClasses, and variable
    maybeRemoveClasses-->>FormidableAdminJS: Return updated class string
    FormidableAdminJS-->>User: Update form field with new classes

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.