Output custom css classes when rendering forms by AbdiTolesa · Pull Request #2194 · Strategy11/formidable-forms

AbdiTolesa · 2025-01-02T10:09:50Z

Fix https://github.com/Strategy11/formidable-pro/issues/5552

coderabbitai · 2025-01-02T10:11:54Z

Walkthrough

The pull request modifies the simple_form_render method in the FrmSimpleBlocksController class to dynamically add CSS classes to forms. When a className attribute is provided, the method uses a regular expression to insert the custom class into the form's existing class list. This enhancement allows for more flexible form styling by enabling developers to append custom CSS classes to forms during rendering.

Changes

File	Change Summary
`classes/controllers/FrmSimpleBlocksController.php`	Added conditional logic to dynamically insert custom CSS classes into form rendering using regex replacement

Possibly related PRs

Remove layout classes when one is added #1803: Introduces functions for managing layout classes in form fields
Fix centered submit button bottom margin value with modern dark theme #2195: Modifies margin-bottom property for submit buttons, related to form styling

Suggested reviewers

Crabcyborg

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf82be6 and c4cf8b9.

📒 Files selected for processing (1)

classes/controllers/FrmSimpleBlocksController.php (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

classes/controllers/FrmSimpleBlocksController.php

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a702b3 and b4de3bf.

📒 Files selected for processing (1)

classes/controllers/FrmSimpleBlocksController.php (1 hunks)

…rk theme" This reverts commit cf82be6.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

css/_single_theme.css.php (1)

257-269: Double-check array-based margin parsing for corner cases.

This logic nicely incorporates the standard 1, 2, 3, or 4-value CSS margin expansions. However, if $submit_margin has extra spaces or an unexpected format (e.g., line breaks), explode(' ', $submit_margin) may yield unintended results or empty array elements. Consider trimming the string or using a more robust approach to guard against malformed inputs.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fedb3a6 and cf82be6.

📒 Files selected for processing (1)

css/_single_theme.css.php (1 hunks)

lauramekaj1

@AbdiTolesa I tested this and now it's working as expected. Thank you!

truongwp

This looks good. Thanks @AbdiTolesa!

Crabcyborg

Thank you @AbdiTolesa @truongwp and @lauramekaj1 for working on this!

This looks good to me.

🚀

Output custom css classes when rendering forms

b4de3bf

coderabbitai Bot reviewed Jan 2, 2025

View reviewed changes

Comment thread classes/controllers/FrmSimpleBlocksController.php

AbdiTolesa added run analysis run tests labels Jan 2, 2025

Make replacement more robust

fedb3a6

AbdiTolesa requested a review from lauramekaj1 January 2, 2025 10:31

AbdiTolesa added 2 commits January 2, 2025 16:14

Fix centered submit button bottom margin value with modern dark theme

cf82be6

Revert "Fix centered submit button bottom margin value with modern da…

368351f

…rk theme" This reverts commit cf82be6.

coderabbitai Bot reviewed Jan 2, 2025

View reviewed changes

Escape custom css class rendered

c4cf8b9

lauramekaj1 approved these changes Jan 13, 2025

View reviewed changes

AbdiTolesa requested a review from truongwp January 14, 2025 09:14

truongwp approved these changes Jan 14, 2025

View reviewed changes

truongwp requested a review from Crabcyborg January 14, 2025 17:22

Crabcyborg approved these changes Jan 15, 2025

View reviewed changes

Crabcyborg added this to the 6.17.2 milestone Jan 15, 2025

Crabcyborg merged commit 7d0b0dc into master Jan 15, 2025

Crabcyborg deleted the issue-5552-output_custom_css_classes_when_rendering_forms branch January 15, 2025 15:07

coderabbitai Bot mentioned this pull request Jan 20, 2025

Fix auto width issue with different label positions #2208

Merged

2 tasks

coderabbitai Bot mentioned this pull request Feb 6, 2025

Make admin nav responsive #2241

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Output custom css classes when rendering forms#2194

Output custom css classes when rendering forms#2194
Crabcyborg merged 5 commits into
masterfrom
issue-5552-output_custom_css_classes_when_rendering_forms

AbdiTolesa commented Jan 2, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jan 2, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

lauramekaj1 left a comment

Uh oh!

truongwp left a comment

Uh oh!

Crabcyborg left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AbdiTolesa commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

lauramekaj1 left a comment

Choose a reason for hiding this comment

Uh oh!

truongwp left a comment

Choose a reason for hiding this comment

Uh oh!

Crabcyborg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AbdiTolesa commented Jan 2, 2025 •

edited

Loading

coderabbitai Bot commented Jan 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)