Start working on readme for version 6.12#1926
Conversation
WalkthroughVersion 6.12 introduces significant enhancements to functionality, accessibility, and compatibility within the plugin. Key updates include an overhaul of default form styles, improved accessibility with screen reader support, resolution of rendering issues with Turnstile captcha, and validation enhancements for field length limits. Deprecated functions have been removed to streamline code maintenance, ensuring a smoother user experience while maintaining compatibility across various WordPress versions. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (10)
readme.txt (2)
375-375: Clarify the update on form style settings.The description of the update to form style settings could be more explicit about the impact on existing sites.
Consider rephrasing for clarity:
- New: Many default form style settings have been updated. Existing sites will continue to use their existing default settings. To experience the new default style settings, access the list of styles from the style tab in form settings and select Reset to Defaults from the dropdown menu for a target style. + New: Many default form style settings have been updated. Existing sites will retain their current default settings unless manually reset. To apply the new default style settings, navigate to the style tab in form settings and select 'Reset to Defaults' for the desired style.
383-383: Clarify the removal of the HTML5 setting.The statement about the HTML5 setting removal could be clearer.
Consider rephrasing for clarity:
- The setting to use HTML5 has been removed. This is now always true for all sites. + The option to disable HTML5 has been removed. HTML5 is now enforced for all sites.changelog.txt (8)
3-3: Clarify style reset instructions.The instructions for resetting to default style settings could be more explicit. Consider adding a step-by-step guide or a link to documentation.
5-5: Clarify Turnstile captcha fix.The fix for Turnstile captcha rendering twice should specify the conditions under which this issue occurred, if applicable.
6-6: Compatibility check details.The extra compatibility check for older WordPress versions should specify what was checked or improved for clarity.
7-7: Submit button visual bug fix.Consider providing more details about the visual bug with the submit button to help users understand the impact of the fix.
8-8: Character validation fix.The fix for character validation should specify which types of characters were affected to provide more context.
10-10: Sync improvements.The updates to improve syncing of field options and conditional logic settings should mention any specific issues that were addressed.
11-11: HTML5 setting change.The removal of the HTML5 setting and making it always true should be communicated clearly to users, as it may affect form behavior.
13-13: JavaScript function removal.The removal of the deprecated JavaScript function should include information on alternatives or replacements if needed.
| * Fix: Turnstile captcha widgets were rendering twice. | ||
| * Fix: An extra check has been added to improve compatibility with older versions of WordPress before version 6.5. | ||
| * Fix: The submit button would appear as an entry table row on the entry view admin page. | ||
| * Fix: When validating field length limits, some characters including types with accents were not getting counted as expected and could fail validation. |
There was a problem hiding this comment.
Add a missing comma for clarity.
A comma is needed after "some characters" to improve readability.
Use this diff to add the missing comma:
- Fix: When validating field length limits, some characters including types with accents were not getting counted as expected and could fail validation.
+ Fix: When validating field length limits, some characters, including types with accents, were not getting counted as expected and could fail validation.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * Fix: When validating field length limits, some characters including types with accents were not getting counted as expected and could fail validation. | |
| * Fix: When validating field length limits, some characters, including types with accents, were not getting counted as expected and could fail validation. |
Tools
LanguageTool
[uncategorized] ~380-~380: Possible missing comma found.
Context: ...en validating field length limits, some characters including types with accents were not g...(AI_HYDRA_LEO_MISSING_COMMA)
| * Checks have been added to no longer include fields with form state on servers where open SSL is not installed. This is to improve compatibility. | ||
| * Some updates have been made to improve the syncing of field option updates and conditional logic settings. | ||
| * The setting to use HTML5 has been removed. This is now always true for all sites. | ||
| * Some old deprecated PHP functions have been removed including FrmAppController::include_embed_form_icons and FrmAppController::get_form_shortcode. |
There was a problem hiding this comment.
Deprecation of PHP functions.
The removal of deprecated PHP functions should include guidance on any necessary code changes for users who relied on these functions.
Do you want me to provide a guide or open a GitHub issue to help users transition away from these deprecated functions?
1 participant
No description provided.