Update readme 6.26#2638
Merged
Merged
Conversation
Contributor
WalkthroughAdds changelog and readme entries for v6.26 and v6.25.1 (features, fixes, and version metadata), and removes three public API entities: the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
readme.txt (1)
374-387: Polish phrasing and consistency in 6.26 notes.Small editorial tweaks for clarity and convention; suggested diff below.
- * New: Gutenberg blocks now use API version 3. As of WordPress 6.9, a deprecated message would appear for older block API versions. + * New: Gutenberg blocks now use API version 3. As of WordPress 6.9, a deprecation message appears for older block API versions. - * New: 12 Fields can now be added to a row in the form builder, up from the previous limit of 6. + * New: 12 fields can now be added to a row in the form builder, up from the previous limit of 6. - * New: An htaccess file is now included that prevents access to text files included in this plugin on Apache servers. + * New: An .htaccess file is now included to prevent access to text files included in this plugin on Apache servers. - * New: The first name field in a form will now automatically include the given-name and family-name autocomplete attributes to improve accessibility and user experience. + * New: Name fields now automatically include the appropriate autocomplete attributes (given-name, family-name) on their respective inputs to improve accessibility and user experience. - * Fix: Square would throw a styling error when using a style with comma separated font family options. To prevent this error, the first font is used only. + * Fix: Square would throw a styling error when using a style with comma-separated font-family options. To prevent this error, only the first font is used.changelog.txt (1)
2-14: Mirror the same editorial tweaks here for consistency with readme.Suggested minimal wording/punctuation updates:
- * New: Gutenberg blocks now use API version 3. As of WordPress 6.9, a deprecated message would appear for older block API versions. + * New: Gutenberg blocks now use API version 3. As of WordPress 6.9, a deprecation message appears for older block API versions. - * New: 12 Fields can now be added to a row in the form builder, up from the previous limit of 6. + * New: 12 fields can now be added to a row in the form builder, up from the previous limit of 6. - * New: An htaccess file is now included that prevents access to text files included in this plugin on Apache servers. + * New: An .htaccess file is now included to prevent access to text files included in this plugin on Apache servers. - * New: The first name field in a form will now automatically include the given-name and family-name autocomplete attributes to improve accessibility and user experience. + * New: Name fields now automatically include the appropriate autocomplete attributes (given-name, family-name) on their respective inputs to improve accessibility and user experience. - * Fix: Square would throw a styling error when using a style with comma separated font family options. To prevent this error, the first font is used only. + * Fix: Square would throw a styling error when using a style with comma-separated font-family options. To prevent this error, only the first font is used.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
changelog.txt(1 hunks)readme.txt(2 hunks)
🧰 Additional context used
🪛 LanguageTool
readme.txt
[misspelling] ~377-~377: Did you mean “in the past”?
Context: ... for older block API versions. * New: Styles now include a Custom CSS setting in Quick Settin...
(IN_THE_PASSED)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Cypress
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: Cypress
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
readme.txt (1)
7-7: Update the minimum PHP version (repeat of prior feedback).“Requires PHP: 7.0” is outdated for sites on WP 6.9; many plugins now baseline 7.4+, and WordPress officially supports 7.2.24+ while recommending newer 8.x.
Proposed change (adjust upward per your verified compatibility):
-Requires PHP: 7.0 +Requires PHP: 7.4What is WordPress 6.9’s minimum supported PHP version, and what PHP version does WordPress.org currently recommend? Also, do upstream Formidable Forms CI builds pass on PHP 7.4, 8.0, 8.1, 8.2, and 8.3?
🧹 Nitpick comments (2)
changelog.txt (1)
3-11: Tighten wording and fix a few nits (casing, punctuation, accuracy).Suggested edits:
- Prefer “Block API version 3” and present tense for the deprecation note.
- Use “fields” (lowercase), “.htaccess” (with dot), and “comma-separated”.
- Clarify autocomplete phrasing for name inputs.
-* New: Gutenberg blocks now use API version 3. As of WordPress 6.9, a deprecated message would appear for older block API versions. +* New: Gutenberg blocks now use Block API version 3. In WordPress 6.9+, a deprecation notice appears for older block API versions. @@ -* New: 12 Fields can now be added to a row in the form builder, up from the previous limit of 6. +* New: Up to 12 fields can now be added to a row in the form builder, up from the previous limit of 6. -* New: An htaccess file is now included that prevents access to text files included in this plugin on Apache servers. +* New: An .htaccess file is now included that prevents access to text files included in this plugin on Apache servers. -* New: The first name field in a form will now automatically include the given-name and family-name autocomplete attributes to improve accessibility and user experience. +* New: Name field inputs now include appropriate autocomplete attributes (given-name and family-name) to improve accessibility and user experience. @@ -* Fix: Square would throw a styling error when using a style with comma separated font family options. To prevent this error, the first font is used only. +* Fix: Square would throw a styling error when using a style with comma-separated font family options. To prevent this error, the first font is used only.readme.txt (1)
374-388: Mirror the wording/punctuation fixes from changelog.txt for consistency.Apply the same edits here:
-* New: Gutenberg blocks now use API version 3. As of WordPress 6.9, a deprecated message would appear for older block API versions. +* New: Gutenberg blocks now use Block API version 3. In WordPress 6.9+, a deprecation notice appears for older block API versions. @@ -* New: 12 Fields can now be added to a row in the form builder, up from the previous limit of 6. +* New: Up to 12 fields can now be added to a row in the form builder, up from the previous limit of 6. -* New: An htaccess file is now included that prevents access to text files included in this plugin on Apache servers. +* New: An .htaccess file is now included that prevents access to text files included in this plugin on Apache servers. -* New: The first name field in a form will now automatically include the given-name and family-name autocomplete attributes to improve accessibility and user experience. +* New: Name field inputs now include appropriate autocomplete attributes (given-name and family-name) to improve accessibility and user experience. @@ -* Fix: Square would throw a styling error when using a style with comma separated font family options. To prevent this error, the first font is used only. +* Fix: Square would throw a styling error when using a style with comma-separated font family options. To prevent this error, the first font is used only.Also, explicitly label the removals as “Breaking” and add a one‑line migration pointer:
-* The deprecated FrmEDD_SL_Plugin_Updater class has been removed. -* The deprecated frmFrontForm.visible and frmFrontForm.invisible functions have been removed. +* Breaking: Removed FrmEDD_SL_Plugin_Updater (migrate to WordPress plugin update APIs). +* Breaking: Removed frmFrontForm.visible and frmFrontForm.invisible (use CSS classes or current visibility helpers). See migration notes in the docs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
changelog.txt(1 hunks)readme.txt(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Cypress
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: PHP 8 tests in WP trunk
🔇 Additional comments (1)
readme.txt (1)
5-6: Version metadata bump looks good.“Requires at least: 6.3” and “Tested up to: 6.9” align with Block API v3 usage.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
readme.txt (1)
5-8: Requires PHP 7.0 is outdated; raise baseline (at least 7.4) to match current ecosystem.Keep “Requires at least: 6.3” and “Tested up to: 6.9”. Update the PHP minimum to ≥7.4 (or the true minimum your code supports if higher).
What is the officially supported minimum PHP version for WordPress 6.9, and what PHP versions does WordPress.org currently recommend? Provide sources from wordpress.org or make.wordpress.org.Suggested change:
- Requires PHP: 7.0 + Requires PHP: 7.4
🧹 Nitpick comments (2)
readme.txt (1)
376-385: Tighten wording and fix minor copy issues in 6.26 bullets.
- “deprecated message” → “deprecation notice”
- “12 Fields” → “12 fields”
- “htaccess” → “.htaccess”
- “comma separated” → “comma-separated”
- Clarify autocomplete line for name fields.
- * New: Gutenberg blocks now use API version 3. As of WordPress 6.9, a deprecated message would appear for older block API versions. + * New: Gutenberg blocks now use API version 3. As of WordPress 6.9, a deprecation notice appears for older block API versions. - * New: 12 Fields can now be added to a row in the form builder, up from the previous limit of 6. + * New: 12 fields can now be added to a row in the form builder, up from the previous limit of 6. - * New: An htaccess file is now included that prevents access to text files included in this plugin on Apache servers. + * New: An .htaccess file is now included that prevents access to text files bundled with this plugin on Apache servers. - * New: The first name field in a form will now automatically include the given-name and family-name autocomplete attributes to improve accessibility and user experience. + * New: Name fields now automatically set autocomplete attributes (given-name for first name, family-name for last name) to improve accessibility and user experience. - * Fix: Square would throw a styling error when using a style with comma separated font family options. To prevent this error, the first font is used only. + * Fix: Square would throw a styling error when using a style with comma-separated font family options. To prevent this error, only the first font is used.changelog.txt (1)
2-15: Add concise migration notes for breaking removals and apply minor copy edits.
- Append one‑line “Migration:” guidance for the two removals.
- Copy fixes: “deprecation notice”, “12 fields”, “.htaccess”, “comma‑separated”.
- * New: Gutenberg blocks now use API version 3. As of WordPress 6.9, a deprecated message would appear for older block API versions. + * New: Gutenberg blocks now use API version 3. As of WordPress 6.9, a deprecation notice appears for older block API versions. - * New: 12 Fields can now be added to a row in the form builder, up from the previous limit of 6. + * New: 12 fields can now be added to a row in the form builder, up from the previous limit of 6. - * New: An htaccess file is now included that prevents access to text files included in this plugin on Apache servers. + * New: An .htaccess file is now included that prevents access to text files bundled with this plugin on Apache servers. - * New: The first name field in a form will now automatically include the given-name and family-name autocomplete attributes to improve accessibility and user experience. + * New: Name fields now automatically set autocomplete attributes (given-name for first name, family-name for last name) to improve accessibility and user experience. - * Fix: Square would throw a styling error when using a style with comma separated font family options. To prevent this error, the first font is used only. + * Fix: Square would throw a styling error when using a style with comma-separated font family options. To prevent this error, only the first font is used. - * Breaking: The deprecated FrmEDD_SL_Plugin_Updater class has been removed. + * Breaking: The deprecated FrmEDD_SL_Plugin_Updater class has been removed. Migration: switch to WordPress core plugin update APIs (automatic updates) or your existing licensing system that integrates with core. - * Breaking: The deprecated frmFrontForm.visible and frmFrontForm.invisible functions have been removed. + * Breaking: The deprecated frmFrontForm.visible and frmFrontForm.invisible functions have been removed. Migration: use current visibility helpers or CSS/ARIA-based show/hide patterns in your custom code.Optionally, add a “Migration notes for 6.26” doc and link it here for details.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
changelog.txt(1 hunks)readme.txt(2 hunks)
🧰 Additional context used
🪛 LanguageTool
readme.txt
[grammar] ~383-~383: Use a hyphen to join words.
Context: ...ling error when using a style with comma separated font family options. To preven...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: Cypress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.