Skip to content

Update readme for v6.16.3#2176

Merged
Crabcyborg merged 1 commit into
masterfrom
update_readme_6.16.3
Dec 10, 2024
Merged

Update readme for v6.16.3#2176
Crabcyborg merged 1 commit into
masterfrom
update_readme_6.16.3

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 10, 2024

Walkthrough

The pull request updates the Formidable Forms plugin to version 6.16.3, introducing new features such as duplicate entry validation for iOS form resubmissions, updated timestamp formatting in the sidebar, and a new database index for performance improvements. It also includes several fixes related to input validation, error handling, and compatibility with WordPress 6.7+. Additionally, deprecated elements and settings have been removed or relocated to streamline the plugin's functionality and reduce file size.

Changes

File Change Summary
changelog.txt Updated to version 6.16.3; added duplicate entry check, timestamp formatting, database index; multiple fixes and removals.
readme.txt Updated versioning information; noted new features and fixes introduced in version 6.16.3.

Possibly related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (4)
readme.txt (3)

374-377: Important security improvement for duplicate entry validation

The extended duplicate entry validation window (from 60s to 1 month) helps prevent duplicate form submissions on iOS devices, significantly improving form reliability and data integrity.

Consider adding a configurable timeframe setting to allow admins to customize the duplicate entry window based on their needs.


378-379: Database performance optimization

The addition of a new database index for entry count queries is a significant performance improvement that should speed up entry listing and reporting features.

Consider adding documentation about the new index for users upgrading from older versions who may need to manually add it if the upgrade process fails.

🧰 Tools
🪛 LanguageTool

[misspelling] ~378-~378: This word is normally spelled as one.
Context: ... a proper aria-invalid value, and error auto-focusing wouldn't work as expected for name fiel...

(EN_COMPOUNDS_AUTO_FOCUSING)


385-389: Code cleanup and deprecation improvements

Good cleanup of legacy code and assets:

  • Removed old form button settings section
  • Removed deprecated CSS
  • Deprecated global JS functions
  • Removed unused asset file (s11-fp.svg)

This helps reduce the plugin's footprint and maintenance burden.

Consider adding migration code to handle any custom code that may have been relying on the removed functionality.

🧰 Tools
🪛 LanguageTool

[style] ~385-~385: Consider removing “of” to be more concise
Context: ...orm button settings has been removed as all of the settings had been moved. * Some old dep...

(ALL_OF_THE)

changelog.txt (1)

13-16: Cleanup and deprecation updates

A few cleanup items:

  1. Removed form button settings section (settings have been relocated)
  2. Removed deprecated CSS to reduce frontend file size
  3. Deprecated global JS functions frmFrontForm.invisible and frmFrontForm.visible
  4. Removed s11-fp.svg asset file to reduce plugin size

Consider documenting where the form button settings were relocated to help users find them in the new location.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4246989 and 48db63c.

📒 Files selected for processing (2)
  • changelog.txt (1 hunks)
  • readme.txt (2 hunks)
🧰 Additional context used
🪛 LanguageTool
readme.txt

[misspelling] ~378-~378: This word is normally spelled as one.
Context: ... a proper aria-invalid value, and error auto-focusing wouldn't work as expected for name fiel...

(EN_COMPOUNDS_AUTO_FOCUSING)


[grammar] ~384-~384: Did you mean “I”?
Context: ...nberg Form blocks were disabled. * Fix: A cannot access offset of type string on ...

(A_MD_VB)


[style] ~385-~385: Consider removing “of” to be more concise
Context: ...orm button settings has been removed as all of the settings had been moved. * Some old dep...

(ALL_OF_THE)

🔇 Additional comments (3)
readme.txt (1)

377-378: Improved timestamp formatting consistency

The timestamp display now properly respects WordPress format settings, providing better consistency across the application.

🧰 Tools
🪛 LanguageTool

[misspelling] ~378-~378: This word is normally spelled as one.
Context: ... a proper aria-invalid value, and error auto-focusing wouldn't work as expected for name fiel...

(EN_COMPOUNDS_AUTO_FOCUSING)

changelog.txt (2)

2-4: Notable performance and validation improvements in v6.16.3

The latest version includes important changes:

  1. Extended duplicate entry validation from 60 seconds to 1 month for iOS form resubmissions, which helps prevent duplicate submissions
  2. Added database index to form entries table to optimize entry count queries
  3. Updated timestamp display in sidebar to use WordPress format settings

6-12: Several bug fixes and validation improvements

Multiple fixes have been implemented:

  1. Fixed aria-invalid value and error auto-focusing for name fields
  2. Fixed fatal error related to unsupported operand types
  3. Fixed translation loading hook for WP 6.7+ compatibility
  4. Fixed deprecated strpos() message
  5. Added validation for non-existent payments/subscriptions
  6. Fixed form titles/descriptions visibility in Gutenberg blocks

@Crabcyborg Crabcyborg added this to the 6.16.3 milestone Dec 10, 2024
@Crabcyborg Crabcyborg merged commit 13ed394 into master Dec 10, 2024
@Crabcyborg Crabcyborg deleted the update_readme_6.16.3 branch December 10, 2024 14:08
@coderabbitai coderabbitai Bot mentioned this pull request Dec 10, 2024
@coderabbitai coderabbitai Bot mentioned this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant