Move Styles & Scripts settings to Manage Styles tab

[truongwp]

Fixes: https://github.com/Strategy11/formidable-pro/issues/5187

This PR will move 2 settings mentioned in the issue to the Manage Styles tab. We will move the Fade in forms with conditional logic on page load setting to Other section in General Settings tab in another PR in Pro.

[coderabbitai]

Walkthrough

The changes involve modifications to the form management interface, specifically in the handling of styling settings. A new line was added to retrieve application settings in the FrmStylesController, while a section for user-defined styling options was removed from the settings page. Additionally, a new dropdown menu for styling preferences was introduced in the manage.php file, allowing users to specify how form styles are applied across their site.

Changes

File Path	Change Summary
classes/controllers/FrmStylesController.php	Added retrieval of settings using FrmAppHelper::get_settings() in the manage method.
classes/views/frm-settings/general.php	Removed the section for user-defined styling options, including a dropdown for loading styles.
classes/views/styles/manage.php	Introduced a new dropdown for styling preferences, allowing users to choose how form styling is applied.

Tip

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 637c891 and 0a3303e.

Files selected for processing (3)

• classes/controllers/FrmStylesController.php (1 hunks)
• classes/views/frm-settings/general.php (1 hunks)
• classes/views/styles/manage.php (1 hunks)

Files skipped from review due to trivial changes (1)

• classes/views/frm-settings/general.php

Additional comments not posted (3)

classes/views/styles/manage.php (2)

7-23: LGTM!

The code changes are approved. The new dropdown menu enhances the user interface for form styling settings and provides clear choices for users to configure form styling.

---

24-24: LGTM!

The code changes are approved. The do_action function call allows for extensibility by triggering associated actions for general style settings and passing the $frm_settings variable provides access to the current settings.

classes/controllers/FrmStylesController.php (1)

736-736: Verify if the $frm_settings variable is used.

The $frm_settings variable is set but not used in the provided code snippet.

Can you please verify if the $frm_settings variable is used later in the manage function or passed to the manage.php view file? If it's not used, consider removing it to avoid unnecessary function calls and to keep the code clean.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Crabcyborg]

This looks good!

Since the other update is in v6.14 we're less likely to get the other setting showing up on the styles page now.

Thanks @truongwp!

🚀