Optimize how styles are saved in global settings

[Crabcyborg]

Related Slack conversation https://strategy11.slack.com/archives/C799A2R61/p1729188618152819

This update aims to reduce the size of the POST data, reducing the number of input vars to help avoid reaching server limits on the global settings page when there are a lot of forms.

• The prev_style input has been removed as it is no longer required and helps to reduce the number of inputs which we're trying to keep low here.
• The dropdowns now have no name attribute on load, so the data is never sent. This is now defined as data-name and applied later with JS.
• The name attribute is now added when the dropdown is changed, so only changed dropdown data is sent.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the FrmStylesController class, specifically refining the logic in the manage_styles method to streamline how form styles are updated based on POST data. Changes also include alterations to the HTML structure in the styles management view, removing a hidden input and adjusting form data attributes. Additionally, significant updates to the JavaScript file enhance the form builder's functionality, adding new methods and improving user interactions through AJAX and dynamic content management.

Changes

File	Change Summary
classes/controllers/FrmStylesController.php	Updated logic in manage_styles method to simplify style updates based on POST data.
classes/views/styles/_manage-styles-row.php	Removed hidden input for active style ID and changed select name to data-name for form submission.
js/formidable_admin.js	Added multiple new methods and restructured event handlers for improved form builder functionality.

Possibly related PRs

• Update Default Form Styling #1640: Updates default form styling, relating to style management in FrmStylesController.
• Move Styles & Scripts settings to Manage Styles tab #1960: Enhances FrmStylesController, directly connecting to changes in the manage_styles method.
• Issue fixes/ff style update #1974: Updates the style editor, relevant to the management and application of styles.
• improve primary color from quick settings style editor #2054: Enhances primary color settings in the style editor, relevant to form appearance management.

Suggested labels

deploy

Suggested reviewers

• shervElmi

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[engahmeds3ed]

Indeed, that's a brilliant idea.
Tested it on a customer's site with the suggested change and it's working properly.

[Crabcyborg]

Thanks Ahmed!