Revert "Support fields validation with captcha"

[Crabcyborg]

Reverts #1961

I just tested this after merging.
This doesn't appear to really solve the issue.

See #1961 (comment)

[coderabbitai]

Walkthrough

The changes in this pull request focus on restructuring the validation logic within the frmFrontFormJS function in js/formidable.js. The validation check is now conditional, ensuring that form submission only occurs if there are no validation errors. This adjustment prevents submissions with errors and aligns loading indicators with successful validation.

Changes

File	Change Summary
js/formidable.js	Restructured validation logic in frmFrontFormJS to prevent form submission if validation errors are present. Loading indicators are now only shown on successful validation.

Possibly related PRs

• Support fields validation with captcha #1961: This PR modifies the frmFrontFormJS function in js/formidable.js, which is directly related to the changes made in the main PR that also involves the frmFrontFormJS function, focusing on validation logic before form submission.

Suggested labels

run analysis, run tests

Tip

New features

Walkthrough comment now includes:

• Possibly related PRs: A list of potentially related PRs to help you recall past context.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

• Please share any feedback in the discussion post on our Discord.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 89ddae2 and 9fe13f2.

Files selected for processing (1)

• js/formidable.js (1 hunks)

Additional comments not posted (1)

js/formidable.js (1)

1552-1560: Review: Validation and Submission Logic

The changes in lines 1552-1560 introduce a conditional check for form validation errors before proceeding with form submission. This is a crucial improvement as it ensures that forms with validation errors are not submitted, aligning with the PR's objective to enhance form robustness.

• Correctness: The logic correctly checks if the errors object is empty before proceeding.
• Performance: This check should not significantly impact performance as it is a simple conditional check on an object's keys.
• Maintainability: The code is readable and maintainable, using clear variable names and straightforward logic.

Overall, this change is a positive improvement to the form submission process, ensuring that only valid forms are submitted.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.