Support fields validation with captcha

[AbdiTolesa]

Fix https://github.com/Strategy11/formidable-pro/issues/5304

Test Procedure

1. Create a form and add a phone field to it, set the Format to 'International'.
2. Turn on 'Validate this form with javascript' in the form setting.
3. Add a Captcha field, in your global Captcha setting, your set set it to V3 / Invisible captcha.
4. Preview the form.
5. Try submitting a non international phone number like just '1234'.
6. Confirm that the validation fails and the form would not submit.

[coderabbitai]

Walkthrough

The changes made to the frmFrontFormJS function involve restructuring the validation logic to improve control flow. The validation process is now initiated at the beginning of the function, ensuring that any errors are identified before proceeding with the loading indicator and the execution of the invisible reCAPTCHA. This adjustment streamlines the process by preventing unnecessary loading states when validation errors are present.

Changes

File	Change Summary
js/formidable.js	Consolidated validation logic in frmFrontFormJS function by moving validateFormSubmit to the start, ensuring errors are checked before showing the loading indicator and executing reCAPTCHA.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Form
    participant Validator
    participant reCAPTCHA

    User->>Form: Submit Form
    Form->>Validator: Validate Form
    alt No Errors
        Form->>Form: Show Loading Indicator
        Form->>reCAPTCHA: Execute reCAPTCHA
    else Errors
        Form->>Form: Show Validation Errors
    end

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ec473b0 and 6be11f4.

Files selected for processing (1)

• js/formidable.js (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• js/formidable.js

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[garretlaxton]

This works great!

[truongwp]

This looks good. Thanks @AbdiTolesa!

[Crabcyborg]

Thank you @AbdiTolesa @truongwp and @garretlaxton for working on this!

I think this looks good to merge.

🚀

[Crabcyborg]

Nevermind!

I spoke too soon.

I'm reverting this #1973

There's a reason why it processes the captcha before it does the JS validation.

After the JS validation happens, the captcha goes red and I can't submit my form.

Screen.Recording.2024-09-09.at.1.19.17.PM.mov

[AbdiTolesa]

@Crabcyborg I tested this again following your steps but I can't trigger the captcha error, here is my screen record:

[Crabcyborg]

@AbdiTolesa I'm not sure why it isn't failing for you. It should be failing when validateRecaptcha is called unless your CAPTCHA has already validated for some reason.

Since validateRecaptcha is called before an invisible reCAPTCHA has had the chance to run, the function will return an error.

I was able to fix my issue by avoiding the call to validateRecaptcha when the captcha is invisible.

I have a new PR here #2003