Do not validate confirmation field when main field loses focus

[truongwp]

Fixes https://github.com/Strategy11/formidable-pro/issues/4733

Steps to replicate:

• Create a form with a password field and enable the password confirmation.
• Enable Validate this form with javascript for this form.
• Preview the form, fill in a password then click outside of the field, the confirm password error shows.
  (this happens with any fields support confirmation field)

Screen.Recording.2024-09-17.at.22.48.54.mov

After this fix:
The confirmation validation only triggers when submit form or when the value of the confirmation field changes and then loses focus.

Screen.Recording.2024-09-17.at.22.52.02.mov

[coderabbitai]

Warning

Rate limit exceeded

@Crabcyborg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 49 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 89d4d95 and 258d388.

Walkthrough

The changes in this pull request enhance the validation logic within the frmFrontFormJS function by adding an onSubmit parameter to several validation functions. This parameter allows for conditional validation behavior based on whether the form is being submitted. New checks for confirm fields are introduced, improving the overall validation process.

Changes

File	Change Summary
js/formidable.js	- Added function validateFieldValue(field, errors, onSubmit) - Added function shouldCheckConfirmField(field, onSubmit) - Modified function checkEmailField(field, errors, onSubmit) - Modified function checkPasswordField(field, errors, onSubmit)

Possibly related PRs

• Support fields validation with captcha #1961: This PR modifies the frmFrontFormJS function, focusing on enhancing validation logic in the context of captcha integration.

Suggested labels

run tests

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[garretlaxton]

This works great!

[Crabcyborg]

Thanks @truongwp and @garretlaxton for working on this!

I was noticing an issue with blank confirmation fields not blocking the form from submitting, but it was also happening on master.

This update makes that update more clear since you only ever see the errors for a split second and then the form submits and shows the error again with PHP now.

#2002

After merging that into this PR I don't see any other issues. This all works great now.

🚀