Remove jquery when validating on change

[Crabcyborg]

Related issue https://github.com/Strategy11/formidable-pro/issues/5002

This removes a reference to .closest() and .hasClass.

[coderabbitai]

Walkthrough

The changes in this pull request focus on optimizing the maybeValidateChange function within the frmFrontFormJS module by replacing jQuery methods with native DOM methods for identifying the closest form element. The update maintains the existing functionality related to form validation while improving performance. Minor formatting and comment adjustments were also made, but these do not impact the code's logic.

Changes

File	Change Summary
js/formidable.js	Updated maybeValidateChange to use field.closest('form') instead of jQuery for form identification; retained class check for frm_js_validate; minor formatting and comment updates.

Possibly related PRs

• Do not validate confirmation field when main field loses focus #1995: This PR modifies the validation logic in the frmFrontFormJS module, which is directly related to the changes made in the maybeValidateChange function regarding form validation.
• Stop using jQuery for required field validation #2109: This PR also focuses on removing jQuery dependencies in the frmFrontFormJS module, similar to the changes made in the maybeValidateChange function, enhancing performance by using vanilla JavaScript.

Suggested labels

run analysis, run tests

Suggested reviewers

• garretlaxton

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

js/formidable.js (1)

279-280: LGTM! Good optimization by using native DOM methods.

The change successfully replaces jQuery's form lookup with the native closest() method and custom hasClass() helper function. This optimization maintains the same functionality while improving performance by removing the jQuery dependency.

Consider adding a null check before accessing the form's classList to make the code more defensive:

-		if ( form && hasClass( form, 'frm_js_validate' ) ) {
+		if ( form?.classList && hasClass( form, 'frm_js_validate' ) ) {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5340b69 and 00076be.

📒 Files selected for processing (1)

• js/formidable.js (1 hunks)