Skip to content

Fix missing checkbox marker in backend#1977

Merged
Crabcyborg merged 3 commits into
masterfrom
fix-missing-checkbox-marker-backend
Sep 12, 2024
Merged

Fix missing checkbox marker in backend#1977
Crabcyborg merged 3 commits into
masterfrom
fix-missing-checkbox-marker-backend

Conversation

@shervElmi
Copy link
Copy Markdown
Contributor

@shervElmi shervElmi commented Sep 11, 2024

This PR fixes the missing checkbox marker in the backend when editing a checkbox. It also resolves a frontend issue where themes apply a margin to the checkbox input::before selector.

Related Issue

https://github.com/Strategy11/formidable-pro/issues/5353

Frontend steps to reproduce

  1. Activate the Twenty Twenty theme.
  2. Add a checkbox to a form and preview the form.
  3. Ensure the checkbox displays without any style issues.

Frontend - Before/After

CleanShot 2024-09-11 at 20 13 58@2x

CleanShot 2024-09-11 at 20 05 04@2x

Backend steps to reproduce

  1. Go to an entry that contains a checkbox.
  2. Ensure the checkbox displays without any style issues.

Backend - Before/After

CleanShot 2024-09-11 at 20 11 56@2x

CleanShot 2024-09-11 at 20 11 06@2x

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 11, 2024

Walkthrough

This pull request introduces changes to two CSS files, css/custom_theme.css.php and css/frm_admin.css. The first file adds a margin: 0; rule to an existing CSS block, affecting the layout of a specific element. The second file enhances the styling of checked checkbox elements by broadening the scope of styling rules and replacing a specific SVG image with a more flexible background image approach for improved visual consistency.

Changes

File Change Summary
css/custom_theme.css.php Added margin: 0; to an existing CSS block.
css/frm_admin.css Enhanced styling for checked checkboxes, added a new selector for checkboxes in #wpbody-content, and replaced SVG image with a responsive background image for checkbox indicators.

Possibly related PRs


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 031a088 and bdb8fb0.

Files selected for processing (1)
  • css/frm_admin.css (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • css/frm_admin.css

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shervElmi
Copy link
Copy Markdown
Contributor Author

@garretlaxton, I’ve checked other admin pages to ensure they look good. Could you also check them? Thanks!

Copy link
Copy Markdown

@garretlaxton garretlaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Comment thread css/frm_admin.css Outdated
Comment thread css/frm_admin.css Outdated
@Crabcyborg Crabcyborg added this to the 6.15 milestone Sep 12, 2024
Copy link
Copy Markdown
Contributor

@Crabcyborg Crabcyborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shervElmi and @garretlaxton!

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants