Add a note about tracking to page content setting

[Crabcyborg]

Fixes https://github.com/Strategy11/formidable-pro/issues/3268

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

A new informational note has been added to the show_page_settings method in the FrmOnSubmitHelper class. This note clarifies that while the selected page's contents will be displayed, it will not trigger a full page load, which may affect standard URL tracking mechanisms like Google Analytics. It recommends using the "Redirect to URL" setting for proper tracking. Additionally, the localization file formidable.pot has been updated with a new creation date and adjustments to line references for various message strings without introducing new functionality.

Changes

File	Change Summary
classes/helpers/FrmOnSubmitHelper.php	Added an informational note in the show_page_settings method regarding page display and tracking.
languages/formidable.pot	Updated POT-Creation-Date and adjusted line numbers for various message strings related to UI prompts and form actions.

Possibly related PRs

• Add a note about tracking to page content setting #2008: This PR directly relates to the main PR as it also modifies the show_page_settings method in the FrmOnSubmitHelper class, adding an informational note about tracking, which is the same change made in the main PR.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

classes/helpers/FrmOnSubmitHelper.php (1)

138-140: Excellent addition of informative note about tracking limitations.

The added note provides valuable information to users about the behavior of the page content display feature and its implications for tracking. It correctly highlights potential issues with tracking mechanisms like Google Analytics and offers a helpful suggestion to use the "Redirect to Url" setting for tracking purposes.

Consider breaking the note into shorter sentences or bullet points for improved readability. For example:

<div class="frm_note_style">
    <?php
    echo esc_html__(
        "Please note:\n" .
        "• The contents of the selected page will be displayed without triggering a full page load.\n" .
        "• Standard URL tracking mechanisms (e.g., Google Analytics) will not work as expected.\n" .
        "• For tracking purposes, consider using the 'Redirect to Url' setting instead.",
        'formidable'
    );
    ?>
</div>

This format may be easier for users to scan and understand quickly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e88bf4d and 9ad179a.

📒 Files selected for processing (1)

• classes/helpers/FrmOnSubmitHelper.php (1 hunks)