Skip to content

Add a note about tracking to page content setting #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 4 commits into from
Sep 26, 2024
Merged

Add a note about tracking to page content setting #2008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ad179a
Add a note about tracking to page content setting
Crabcyborg Sep 25, 2024
8273092
Update the text in note based on Steves response
Crabcyborg Sep 26, 2024
4efd7a0
Ignore long line phpcs rule
Crabcyborg Sep 26, 2024
8b13b87
Update pot file
Crabcyborg Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions classes/helpers/FrmOnSubmitHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ public static function show_page_settings( $args ) {
$name_attr = $args['action_control']->get_field_name( 'success_page_id' );
?>
<div class="frm_form_field">
<div class="frm_note_style">
<?php esc_html_e( 'NOTE: The selected page content will be displayed, but the full page will not be loaded. Traditional URL tracking in Google Analytics and similar tools won\'t register a page load event. If precise tracking is essential, consider using the \'Redirect to URL\' option.', 'formidable' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong ?>
</div>
<label for="<?php echo esc_attr( $name_attr ); ?>" class="screen-reader-text">
<?php esc_html_e( 'Select a page', 'formidable' ); ?>
</label>
Expand Down
Loading