Move AJAX hooks into load_ajax_hooks function

[Crabcyborg]

Some of these were registered in the wrong place.

This should help cut back on the number of hooks on a normal admin page load, slightly.

[coderabbitai]

Walkthrough

The changes in the pull request focus on modifications to the FrmHooksController class within the FrmHooksController.php file. New AJAX action hooks were added to the load_ajax_hooks method to manage application data retrieval and review dismissal. Concurrently, two existing action hooks were removed from the load_admin_hooks method, indicating a restructuring of how certain functionalities are handled within the admin interface.

Changes

File Path	Change Summary
classes/controllers/FrmHooksController.php	- Added new action hooks in load_ajax_hooks for AJAX requests: frm_get_applications_data and frm_dismiss_review. - Removed action hooks from load_admin_hooks: frm_settings_tab and frm_page_search. - Updated method signatures for both load_ajax_hooks and load_admin_hooks.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AjaxHandler
    participant FrmApplicationsController
    participant FrmAppController

    User->>AjaxHandler: Request applications data (wp_ajax_frm_get_applications_data)
    AjaxHandler->>FrmApplicationsController: Call get_applications_data()
    FrmApplicationsController-->>AjaxHandler: Return applications data
    AjaxHandler-->>User: Send applications data

    User->>AjaxHandler: Dismiss review (wp_ajax_frm_dismiss_review)
    AjaxHandler->>FrmAppController: Call dismiss_review()
    FrmAppController-->>AjaxHandler: Confirm dismissal
    AjaxHandler-->>User: Confirmation of dismissal

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c458781 and bd8ff27.

📒 Files selected for processing (1)

• classes/controllers/FrmHooksController.php (2 hunks)

🔇 Additional comments (2)

classes/controllers/FrmHooksController.php (2)

265-266: LGTM! Appropriate relocation of AJAX hooks

Moving these settings-related AJAX hooks from load_admin_hooks to load_ajax_hooks improves code organization by grouping all AJAX operations together.

---

292-297: Verify access requirements for applications data endpoint

The new AJAX hooks are properly placed and follow the established pattern. However, please verify if the applications data endpoint (frm_get_applications_data) should be accessible to non-logged-in users. If public access is required, consider adding a corresponding wp_ajax_nopriv_ hook.

✅ Verification successful

AJAX hook access control is correctly implemented

The frm_get_applications_data endpoint is properly secured and should only be available to logged-in users with appropriate permissions:

• The endpoint checks for the 'frm_view_forms' capability using FrmAppHelper::permission_check()
• It verifies the AJAX nonce with check_ajax_referer()
• Additional capability checks are performed based on the view type
• The applications page is rendered in an admin context

The current implementation of wp_ajax_ without wp_ajax_nopriv_ is correct and secure.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if applications data is used in public-facing components
# This would help determine if we need a nopriv version of the hook

# Search for references to applications data in template/view files
echo "Searching for applications data usage in templates..."
rg -l "applications.?data" --type html --type php

# Search for public-facing components that might need applications data
echo "Searching for public references to applications..."
rg -l "FrmApplicationsController" --type php

Length of output: 609

---

Script:

#!/bin/bash
# Let's examine the FrmApplicationsController to understand the context and access requirements

# Check the implementation of get_applications_data
echo "Checking get_applications_data implementation:"
rg "function get_applications_data" -A 10 classes/controllers/FrmApplicationsController.php

# Check if there are any capability checks in the controller
echo -e "\nChecking for capability checks:"
rg "current_user_can|check_permission|capability" classes/controllers/FrmApplicationsController.php

# Check where applications are rendered/used
echo -e "\nChecking applications/index.php content:"
cat classes/views/applications/index.php

Length of output: 2025

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.