Skip to content

Stop using jQuery for required field validation #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 1 commit into from
Nov 14, 2024
Merged

Stop using jQuery for required field validation #2109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions js/formidable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,23 +163,32 @@ function frmFrontFormJS() {
}

function validateForm( object ) {
let errors, r, rl, n, nl, fields, field, requiredFields;
let errors, n, nl, fields, field;

errors = [];

// Make sure required text field is filled in
requiredFields = jQuery( object ).find(
'.frm_required_field:visible input, .frm_required_field:visible select, .frm_required_field:visible textarea'
).filter( ':not(.frm_optional)' );
if ( requiredFields.length ) {
for ( r = 0, rl = requiredFields.length; r < rl; r++ ) {
if ( hasClass( requiredFields[r], 'ed_button' ) ) {
// skip rich text field buttons.
continue;
const vanillaJsObject = 'function' === typeof object.get ? object.get( 0 ) : object;

// Required field validation.
vanillaJsObject?.querySelectorAll( '.frm_required_field' ).forEach(
requiredField => {
const isVisible = requiredField.offsetParent !== null;
if ( ! isVisible ) {
return;
}
errors = checkRequiredField( requiredFields[r], errors );

requiredField.querySelectorAll( 'input, select, textarea' ).forEach(
requiredInput => {
if ( hasClass( requiredInput, 'frm_optional' ) || hasClass( requiredInput, 'ed_button' ) ) {
// skip rich text field buttons.
return;
}

errors = checkRequiredField( requiredInput, errors );
}
);
}
}
);

fields = jQuery( object ).find( 'input,select,textarea' );
if ( fields.length ) {
Expand Down