Fix string offset access of string issue

[Crabcyborg]

Related ticket https://secure.helpscout.net/conversation/2784288062/217416

Pre-release
formidable-6.16.3b.zip

[coderabbitai]

Walkthrough

The pull request introduces modifications to the FrmFieldsHelper and FrmFormsHelper classes. In FrmFieldsHelper, the show_add_field_buttons method is updated to improve error handling by checking for the existence of the icon key before using strpos. In FrmFormsHelper, two new methods, get_field_link_name and get_field_link_icon, are added, along with updates to existing methods to enhance functionality, performance, and validation of form submissions.

Changes

File Path	Change Summary
classes/helpers/FrmFieldsHelper.php	- Updated show_add_field_buttons method to check if icon key exists before calling strpos.
classes/helpers/FrmFormsHelper.php	- Added methods: get_field_link_name and get_field_link_icon for retrieving field name and icon. - Updated insert_opt_html to include caching for field selection data. - Modified get_invalid_error_message to accept a new $args parameter. - Introduced check_for_warnings method for validating form settings and sanitizing input.

Possibly related PRs

• Improve support for null when preparing esc value #2145: This PR addresses a deprecation warning related to the strpos() function, which is relevant to the changes made in the main PR that also involve the strpos() function in the context of checking the icon property in the FrmFieldsHelper class.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

classes/helpers/FrmFormsHelper.php (1)

Line range hint 2146-2146: Ensure strict comparison in strpos usage

The use of strpos without strict comparison may lead to unexpected behavior when the substring is at the beginning of the string (position 0). Since strpos returns 0 in such cases, which is evaluated as false, the condition will not work as intended. To accurately detect the presence of the substring, use !== false in the comparison.

Apply this diff to fix the issue:

-$has_show_upgrade_class = isset( $field_type['icon'] ) && strpos( $field_type['icon'], ' frm_show_upgrade' );
+$has_show_upgrade_class = isset( $field_type['icon'] ) && strpos( $field_type['icon'], ' frm_show_upgrade' ) !== false;

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5262a01 and 2c7fe6a.

📒 Files selected for processing (2)

• classes/helpers/FrmFieldsHelper.php (1 hunks)
• classes/helpers/FrmFormsHelper.php (2 hunks)

🔇 Additional comments (2)

classes/helpers/FrmFormsHelper.php (2)

Line range hint 219-228: get_field_link_name method implemented correctly

The new get_field_link_name method properly handles input that can be either an array or a string, ensuring the correct field label is returned in both cases. This addition enhances code readability and reusability.

---

Line range hint 235-244: get_field_link_icon method improves error handling

The get_field_link_icon method checks for the existence of the 'icon' key in the $field_type array and assigns a default icon if it's not present. This prevents potential undefined index errors and aligns with best practices for handling array keys.