Fix php warnings

[Crabcyborg]

After importing some forms with Pro fields into Lite, after falling back, some of the Lite code is throwing warnings.

[coderabbitai]

Walkthrough

This pull request introduces two conditional logic improvements. In the helper file, the condition in the include_other_input method is updated to use !empty() when checking the field’s multiple property, ensuring only non-empty values are considered. In the view file, the ternary logic for the data-formid attribute now uses an additional isset() check for $field['form_select'] to avoid undefined index issues. No changes were made to the declarations of exported or public entities.

Changes

Files	Change Summary
classes/helpers/FrmFieldsHelper.php classes/views/frm-forms/add_field.php	Updated conditional checks to improve robustness. In FrmFieldsHelper.php, the multiple property check now explicitly verifies non-empty values. In add_field.php, an isset() check is added to safely reference $field['form_select'] before using it in the ternary expression for the data-formid attribute.

Possibly related PRs

• Fix string offset access of string issue #2170: Modifies a different method (show_add_field_buttons) in the same helper class, indicating a common focus on refining conditional logic.

Suggested reviewers

• lauramekaj1
• truongwp

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b3499f and bbebd18.

📒 Files selected for processing (2)

• classes/helpers/FrmFieldsHelper.php (1 hunks)
• classes/views/frm-forms/add_field.php (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: Cypress
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk

🔇 Additional comments (2)

classes/helpers/FrmFieldsHelper.php (1)

1529-1530: Improved robustness by adding empty check

The modified condition now uses ! empty( $args['field']['multiple'] ) instead of a direct boolean check, which prevents PHP warnings when the 'multiple' property is not set. This is especially important when handling forms imported from Pro version to Lite version.

classes/views/frm-forms/add_field.php (1)

6-6: Added isset check to prevent undefined index warnings

The condition for setting the data-formid attribute now includes && isset( $field['form_select'] ), which prevents PHP warnings when 'form_select' isn't defined. This improves the robustness of the code when handling fields imported from the Pro version to the Lite version.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.