Move hook to admin hooks

[Crabcyborg]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.97%. Comparing base (18d0f6c) to head (d6d005b).
Report is 43 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2172      +/-   ##
============================================
+ Coverage     26.91%   26.97%   +0.05%     
+ Complexity     8213     8201      -12     
============================================
  Files           127      127              
  Lines         27240    27198      -42     
============================================
+ Hits           7333     7338       +5     
+ Misses        19907    19860      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Walkthrough

The changes involve a modification to the FrmHooksController class in the classes/controllers/FrmHooksController.php file. A new filter hook has been added to the load_admin_hooks method, allowing for the invocation of the FrmFormsController::update_form_builder_fields method when the frm_fields_in_form_builder filter is triggered. This adjustment enhances the extensibility of the form builder functionality without altering the existing logic or control flow of the class.

Changes

File Path	Change Summary
classes/controllers/FrmHooksController.php	Added a filter hook in the load_admin_hooks method: add_filter( 'frm_fields_in_form_builder', 'FrmFormsController::update_form_builder_fields', 10, 2 );

Sequence Diagram(s)

sequenceDiagram
    participant A as Admin
    participant B as FrmHooksController
    participant C as FrmFormsController

    A->>B: Trigger load_admin_hooks
    B->>B: Execute load_admin_hooks
    B->>C: Call update_form_builder_fields
    C-->>B: Return updated fields
    B-->>A: Return to Admin

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3c22d61 and d6d005b.

📒 Files selected for processing (1)

• classes/controllers/FrmHooksController.php (1 hunks)

🔇 Additional comments (1)

classes/controllers/FrmHooksController.php (1)

148-148: LGTM! Verify hook usage consistency.

The addition of the form builder fields filter to admin hooks is appropriate since the form builder is an admin-side feature.

Let's verify the hook usage and parameters:

✅ Verification successful

✓ Hook implementation and usage verified

The filter hook is correctly implemented:

• Method update_form_builder_fields accepts exactly 2 parameters as specified in the hook
• The filter is properly applied in FrmFormsController with correct parameters
• The implementation modifies field icons in the form builder context

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the hook implementation and usage
# 1. Check the method implementation
# 2. Check for any existing usage of this filter

# Check the method implementation to verify it expects 2 parameters
ast-grep --pattern 'function update_form_builder_fields($_,$_){$$$}'

# Check for existing usage of this filter
rg "apply_filters.*frm_fields_in_form_builder" -A 2

Length of output: 423

---

Script:

#!/bin/bash
# Let's verify the method implementation in FrmFormsController
ast-grep --pattern 'class FrmFormsController {
  $$$
  static function update_form_builder_fields($_, $_) {
    $$$
  }
  $$$
}'

Length of output: 130

---

Script:

#!/bin/bash
# Let's try a different approach to find the method implementation
rg "function update_form_builder_fields" -A 5

Length of output: 475

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.