Fix wpml compatibility issue

[Crabcyborg]

Related ticket https://secure.helpscout.net/conversation/2885530761/225900

Pre-release
formidable-6.19.1b.zip

This update helps to prevent WPML from filtering our form actions, so they work as expected.

[coderabbitai]

Walkthrough

This pull request introduces a static method prevent_wpml_translations in the FrmFormActionsController class to bypass WPML translations for a specific post type. The method checks if the provided post type matches the class's static property and returns false to prevent filtering. Additionally, a filter is registered in the load_hooks method of the FrmHooksController class, linking the WPML translation process to the newly defined method.

Changes

File	Change Summary
classes/controllers/FrmFormActionsController.php	Added static method prevent_wpml_translations to check for the post type and bypass WPML filtering by returning false when matched.
classes/controllers/FrmHooksController.php	Updated load_hooks method to add the filter pre_wpml_is_translated_post_type, invoking prevent_wpml_translations with a priority of 10 and two arguments.

Possibly related PRs

• Add check for WP error before trying to inject a suggestion fix #1941: Involves handling WPML translations, with a focus on preventing translations and enhancing error handling.
• Remove old ajax submit compatibillty code #2276: Modifications related to handling WPML translations, integrating the prevent_wpml_translations method into a filter.
• Fix issue with custom style getting unset on form settings update #2139: Directly relates to integrating the prevent_wpml_translations method into the load_hooks function for improved WPML handling.

Suggested reviewers

• AbdiTolesa

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fe90ba and 15d3e50.

📒 Files selected for processing (1)

• classes/controllers/FrmFormActionsController.php (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• classes/controllers/FrmFormActionsController.php

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: Cypress

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

classes/controllers/FrmFormActionsController.php (1)

699-700: Replace version placeholder

The @since x.x in the docblock should be replaced with the actual version number for this release.

- * @since x.x
+ * @since 6.x

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4b3c09 and a5135ab.

📒 Files selected for processing (2)

• classes/controllers/FrmFormActionsController.php (1 hunks)
• classes/controllers/FrmHooksController.php (1 hunks)

🧰 Additional context used

🪛 GitHub Check: Psalm

classes/controllers/FrmHooksController.php

[failure] 75-75: UndefinedMethod
classes/controllers/FrmHooksController.php:75:51: UndefinedMethod: Method FrmFormActionsController::prevent_wpml_translations does not exist (see https://psalm.dev/022)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: Run PHP Syntax inspection (8.3)
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: Cypress

🔇 Additional comments (1)

classes/controllers/FrmFormActionsController.php (1)

706-711: Function logic is correct

The implementation correctly bypasses WPML's translation functionality for the 'frm_form_actions' post type by returning false. This will prevent WPML from filtering form actions based on the active language, which aligns with the PR objective.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

classes/controllers/FrmFormActionsController.php (1)

671-671: Update version placeholder in @SInCE tag

The @since tag contains a placeholder value "x.x" instead of an actual version number. This should be updated to reflect the correct version where this feature is being introduced.

-	 * @since x.x
+	 * @since 6.0 

Note: Replace "6.0" with the actual version number where this feature is being introduced.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5135ab and 2fe90ba.

📒 Files selected for processing (1)

• classes/controllers/FrmFormActionsController.php (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: PHP 7.4 tests in WP trunk

🔇 Additional comments (1)

classes/controllers/FrmFormActionsController.php (1)

667-682: Good implementation of WPML compatibility fix

The method correctly prevents WPML from filtering form actions based on the active language by returning false when the post type is 'frm_form_actions'. This addresses the compatibility issue mentioned in the PR title.