Remove old ajax submit compatibillty code

[Crabcyborg]

We don't need the old checks anymore. v6.2 is old enough, going back to Apr 6, 2023.

[coderabbitai]

Walkthrough

The pull request simplifies the AJAX submission functionality by removing the Pro-version dependency in multiple components. The controller now solely checks if a form is AJAX-enabled and appends the corresponding CSS class when applicable. In parallel, the settings view renders the AJAX submission checkbox unconditionally. Additionally, the helper method responsible for checking Pro version requirements has been deprecated and now returns a static false.

Changes

File(s)	Change Summary
classes/controllers/FrmFormsController.php classes/views/frm-forms/settings-advanced.php	Removed conditionals based on FrmFormsHelper::should_use_pro_for_ajax_submit(). The controller now always adds the AJAX class if the form is AJAX-enabled, and the settings view always displays the AJAX submit checkbox.
classes/helpers/FrmFormsHelper.php	Deprecated the should_use_pro_for_ajax_submit() method. The original Pro-version check was removed and replaced with a warning via _deprecated_function, returning false instead.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant C as FrmFormsController::form_classes
    participant F as FrmForm
    participant UI as Output Renderer
    U->>C: Request form classes for form
    C->>F: is_ajax_on(form)
    F-->>C: returns (true/false)
    alt AJAX is enabled
        C->>UI: Append 'frm_ajax_submit' class
    else
        C->>UI: Render form without extra class
    end

Loading

sequenceDiagram
    participant U as User
    participant V as Settings UI (frm-forms/settings-advanced)
    U->>V: Load settings page
    V->>UI: Render AJAX submission checkbox unconditionally

Loading

Possibly related PRs

• Drop deprecated frmUpdateField front end function #1812: Involved removal of a similar Pro-version check method, directly affecting AJAX submission logic in the controller.

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8748e5 and 817077a.

📒 Files selected for processing (3)

• classes/controllers/FrmFormsController.php (1 hunks)
• classes/helpers/FrmFormsHelper.php (1 hunks)
• classes/views/frm-forms/settings-advanced.php (1 hunks)

🧰 Additional context used

🧬 Code Definitions (1)

classes/views/frm-forms/settings-advanced.php (1)

classes/helpers/FrmAppHelper.php (3) (3)

• checked (2089:2093)
• FrmAppHelper (6:4460)
• tooltip_icon (4386:4398)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: PHP 7.4 tests in WP trunk

🔇 Additional comments (3)

classes/views/frm-forms/settings-advanced.php (1)

110-118: AJAX setting is now unconditionally available

The AJAX submission checkbox is now always displayed instead of being conditionally shown based on Pro version availability. This simplifies the UI and codebase by removing outdated compatibility checks.

classes/controllers/FrmFormsController.php (1)

1711-1713: Simplified AJAX form class logic

The conditional logic for adding the AJAX submit class has been simplified by removing the dependency on FrmFormsHelper::should_use_pro_for_ajax_submit(). Now the code simply checks if AJAX is enabled for the form, making the codebase cleaner and more maintainable.

classes/helpers/FrmFormsHelper.php (1)

1863-1876: Appropriate removal of outdated compatibility code.

The changes replace the should_use_pro_for_ajax_submit() method with a deprecated version that simply returns false instead of performing compatibility checks for Pro version 6.2 or earlier. This aligns with the PR objective of removing unnecessary legacy code, as version 6.2 from April 2023 is now considered outdated.

The _deprecated_function() call properly signals to developers that they should no longer rely on this method in their code.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.