Add null check for form name

[Crabcyborg]

I added a null in my database when testing and now I see this deprecated message.

PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/src/wp-content/plugins/formidable/classes/helpers/FrmFormsListHelper.php on line 410

[coderabbitai]

Walkthrough

The changes involve a modification to the get_form_name method in the FrmFormsListHelper class. The update enhances the condition that checks if the $form_name variable is empty, expanding it to also consider null values. This adjustment ensures that when $form_name is null, a default title is retrieved, maintaining the method's functionality while improving its robustness.

Changes

File	Change Summary
classes/helpers/FrmFormsListHelper.php	Updated get_form_name method to check if $form_name is null or an empty string.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FrmFormsListHelper
    participant FrmFormsHelper

    User->>FrmFormsListHelper: Request form name
    FrmFormsListHelper->>FrmFormsListHelper: Check if form_name is null or empty
    alt form_name is null
        FrmFormsListHelper->>FrmFormsHelper: Retrieve default title
    else form_name is not null
        FrmFormsListHelper->>User: Return form_name
    end

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

classes/helpers/FrmFormsListHelper.php (1)

410-410: LGTM! The null check enhancement improves robustness.

The updated condition is_null( $form_name ) || trim( $form_name ) == '' properly handles both null values and empty strings, making the code more defensive.

However, for better consistency with PHP best practices, consider using the null coalescing operator:

-		if ( is_null( $form_name ) || trim( $form_name ) == '' ) {
+		if ( trim( $form_name ?? '' ) === '' ) {

This achieves the same result more concisely while maintaining readability. The ?? operator will return an empty string if $form_name is null, which is then trimmed and compared.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b9a2ad7 and 9006a25.

📒 Files selected for processing (1)

• classes/helpers/FrmFormsListHelper.php (1 hunks)

🔇 Additional comments (1)

classes/helpers/FrmFormsListHelper.php (1)

410-412: Verify similar empty checks in the codebase

Let's check if there are similar patterns in the codebase that might benefit from the same null check enhancement.