Add null check for form name in switcher

[Crabcyborg]

I have a form with null for a name, and noticed this message.

PHP Deprecated: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/src/wp-content/plugins/formidable/classes/helpers/FrmFormsHelper.php on line 130

[coderabbitai]

Walkthrough

The pull request modifies the FrmFormsHelper class in the FrmFormsHelper.php file, specifically updating the form_switcher method. The change enhances the handling of the $name variable by extending the existing condition to check for both empty strings and null values. When $name is either empty or null, the method now defaults to using a no-title text, improving the robustness of name handling in the form-related functionality.

Changes

File	Change Summary
classes/helpers/FrmFormsHelper.php	Updated form_switcher method to handle null $name values by adding is_null($name) to the existing condition

Possibly related PRs

• Add a null check to avoid deprecated message when previewing #1742: Adds a null check to avoid deprecated messages, showing a similar approach to handling null values
• Check for null in sanitize_embedded_shortcodes #2074: Introduces a null check in sanitize_embedded_shortcodes method, enhancing null value error handling
• Add null check for form name #2182: Modifies get_form_name method to check for null values, treating null similarly to an empty string

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

classes/helpers/FrmFormsHelper.php (1)

130-130: Consider using type coercion for better null handling.

While the current fix works, you could make the code more robust by using type coercion to ensure strip_tags() always receives a string:

-$name = '' === $name || is_null($name) ? self::get_no_title_text() : strip_tags($name);
+$name = '' === (string)$name ? self::get_no_title_text() : strip_tags((string)$name);

This approach:

1. Handles null values through type coercion
2. Reduces complexity by eliminating the need for an explicit null check
3. Ensures strip_tags() always receives a string

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 076c9e9 and 817a516.

📒 Files selected for processing (1)

• classes/helpers/FrmFormsHelper.php (1 hunks)

🔇 Additional comments (1)

classes/helpers/FrmFormsHelper.php (1)

130-130: LGTM! The null check fixes the deprecation warning.

The addition of is_null($name) check properly handles cases where the form name is null, preventing the PHP deprecation warning when calling strip_tags().