Denylist spam check improvements

[truongwp]

Fixes https://github.com/Strategy11/formidable-pro/issues/5801

Changes:

• Added a toggle to disable denylist spam check.
• All spam checks now don't run when importing.
• Denylist spam check doesn't check password, captcha, signature, radio, checkbox, select field types. But it still check the Other value of radio, checkbox, select field types. To skip for Other value, add other to the skip_field_types of denylist.

[coderabbitai]

Warning

Rate limit exceeded

@truongwp has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 025da6a and 94eeaba.

📒 Files selected for processing (1)

• classes/models/FrmSpamCheckDenylist.php (4 hunks)

"""

Walkthrough

A new "denylist_check" setting was introduced, including its addition to the settings model, usage tracking, and the settings UI. The denylist check logic now references this setting to determine if the denylist feature is enabled. A corresponding checkbox was added to the spam settings section of the captcha settings page. Additionally, spam checking is skipped during import operations.

Changes

File(s)	Change Summary
classes/models/FrmSettings.php	Added public property denylist_check and included it in the default_options() method with a default of 0.
classes/models/FrmSpamCheckDenylist.php	Modified is_enabled() to use the denylist_check setting from global settings instead of a hardcoded value; appended 'password', 'captcha', 'signature', 'checkbox', 'radio', and 'select' to skip_field_types in fill_default_denylist_data(); extended get_values_to_check() to include "Other" values unless skipped.
classes/models/FrmUsage.php	Included 'denylist_check' in the $pass_settings array for usage tracking in the settings() method.
classes/views/frm-settings/captcha/captcha.php	Added a checkbox input for denylist_check in the captcha settings UI.
classes/models/FrmEntryValidate.php	Added early exit in spam_check method to skip spam validation when WP_IMPORTING is defined and true.

Sequence Diagram(s)

sequenceDiagram
    participant Admin as Admin User
    participant UI as Captcha Settings UI
    participant FrmSettings as FrmSettings
    participant FrmSpamCheckDenylist as FrmSpamCheckDenylist

    Admin->>UI: Toggles "Check denylist data" checkbox
    UI->>FrmSettings: Updates denylist_check setting
    FrmSpamCheckDenylist->>FrmSettings: Reads denylist_check via get_settings()
    FrmSpamCheckDenylist->>FrmSpamCheckDenylist: is_enabled() returns value based on setting

Loading

Possibly related PRs

• Antispam improvements #2285: Adds denylist_check property and integrates it into denylist spam check enabling logic in FrmSpamCheckDenylist.
• Track gdpr settings #2300: Adds GDPR-related settings to the $pass_settings array in FrmUsage::settings(), similar to the addition of denylist_check for usage tracking.

Suggested labels

run analysis, deploy, run tests

Suggested reviewers

• Crabcyborg
  """

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Crabcyborg]

Thanks @truongwp!

This looks good to me.

🚀